From: Tejun Heo <tj@kernel.org>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Andy Walls <awalls@md.metrocast.net>,
linux-kernel@vger.kernel.org, nicolas.mailhot@laposte.net,
Jarod Wilson <jarod@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep
Date: Mon, 20 Dec 2010 17:21:10 +0100 [thread overview]
Message-ID: <4D0F8276.9070903@kernel.org> (raw)
In-Reply-To: <AANLkTikuKMLUoVnQsU6QNCnHBgOponJUngHGtyVHk1xK@mail.gmail.com>
Hello,
On 12/20/2010 10:28 AM, Yong Zhang wrote:
> Subject: [PATCH] kthread_work: Make lockdep happy
>
> spinlock in kthread_worker and wait_queue_head in kthread_work
> both should be lockdep annotated.
> So change the interface to make it suiltable for CONFIG_LOCKDEP.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> ---
> I'm not sure if it's possible to define a worker on stack?
> So I left DEFINE_KTHREAD_WORKER() untouched.
Yes, it can, I think. BTW, where are you using kthread_worker? I'm
planning to update its flush semantics similar to that of proper
workqueue so that it's less confusing and switching between the two is
easy, so its usage may change slightly soon, although conversion
shouldn't be difficult.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-12-20 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 12:49 [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep Andy Walls
2010-12-20 7:07 ` Yong Zhang
2010-12-20 9:28 ` Yong Zhang
2010-12-20 16:21 ` Tejun Heo [this message]
2010-12-21 1:54 ` Yong Zhang
2010-12-21 4:40 ` [V2 PATCH] kthread_work: Make lockdep happy Yong Zhang
2010-12-21 12:59 ` Tejun Heo
2010-12-21 13:25 ` Nicolas Mailhot
2010-12-21 16:07 ` Andy Walls
2010-12-22 0:39 ` Andy Walls
2010-12-22 3:12 ` Yong Zhang
2010-12-22 3:23 ` [V3 " Yong Zhang
2010-12-22 9:33 ` Tejun Heo
2010-12-20 17:16 ` [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep Andy Walls
2010-12-21 2:02 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0F8276.9070903@kernel.org \
--to=tj@kernel.org \
--cc=awalls@md.metrocast.net \
--cc=hverkuil@xs4all.nl \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@redhat.com \
--cc=nicolas.mailhot@laposte.net \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox