From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies
Date: Fri, 24 Dec 2010 16:38:41 +0100 [thread overview]
Message-ID: <4D14BE81.6000907@metafoo.de> (raw)
In-Reply-To: <20101224145706.GA16614@opensource.wolfsonmicro.com>
On 12/24/2010 03:57 PM, Mark Brown wrote:
> > On Fri, Dec 24, 2010 at 02:47:55PM +0100, Lars-Peter Clausen wrote:
>> >> The multi-component patch(commit f0fba2ad1) introduced a generic register cache
>> >> framework. Most of the drivers where converted to use this new framework. But
> >
> > No it didn't - soc-cache.c has been present since the middle of 2009.
Hm. Ok, you are right, I've should have checked more closely. Only the allocation of
the register cache was moved from the drivers to the core.
So the commit messages should have been along the lines of:
The multi-component patch(commit f0fba2ad1) moved the alloction of the
register cache from drivers to the ASoC core. While most of the drivers were
converted to respect this change, some still maintain their own register
cache besides the one used and allocated by the core.
Thus the device ends up with two from each other incoherent caches, which
can lead to undefined behaviour.
If there are no other issues with this series, I'll resend it with adjusted commit
messages in a few days.
- Lars
next prev parent reply other threads:[~2010-12-24 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 13:47 [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 1/9] ASoC: codecs: Remove unused reg_cache fields from device structs Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 2/9] ASoC: codecs: max98088: Fix register cache incoherency Lars-Peter Clausen
2010-12-24 13:47 ` [PATCH 3/9] ASoC: codecs: wm8523: " Lars-Peter Clausen
2010-12-24 15:59 ` Mark Brown
2010-12-24 13:47 ` [PATCH 4/9] ASoC: codecs: wm8741: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 5/9] ASoC: codecs: wm8904: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 6/9] ASoC: codecs: wm8955: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 7/9] ASoC: codecs: wm8962: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 8/9] ASoC: codecs: wm9090: " Lars-Peter Clausen
2010-12-24 13:48 ` [PATCH 9/9] ASoC: codecs: wm8753: " Lars-Peter Clausen
2010-12-24 15:50 ` Mark Brown
2010-12-24 14:57 ` [PATCH 0/9] ASoC: codecs: Fix register cache incoherencies Mark Brown
2010-12-24 15:38 ` Lars-Peter Clausen [this message]
2010-12-24 16:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D14BE81.6000907@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox