From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: plyatov@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, geomatsi@gmail.com,
nicolas.ferre@atmel.com, linux@maxim.org.za,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
christian.glindkamp@taskit.de, ryan@bluewatersys.com,
pgsellmann@portner-elektronik.at
Subject: Re: [PATCH v2] ata: pata_at91.c bugfix for high master clock
Date: Fri, 24 Dec 2010 13:30:58 -0500 [thread overview]
Message-ID: <4D14E6E2.3080501@pobox.com> (raw)
In-Reply-To: <4D05FD4C.9040200@ru.mvista.com>
On 12/13/2010 06:02 AM, Sergei Shtylyov wrote:
> On 12-12-2010 22:02, Igor Plyatov wrote:
>>>> static const struct ata_timing initial_timing =
>>>> - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
>>>> + {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0};
>
>>> BTW, you haven't described this in the changelog...
>
>> Here is just a typo fixed for the ata_timing structure. This typo does
>> not have influence on the driver operation, but I do not like to leave
>> such a negligible problem as it is.
>
> You at least should have noted that in the changelog. And as the change
> is unrelated to the other changes you're doing, it's a good practice to
> put it into a separate patch.
Agreed...
prev parent reply other threads:[~2010-12-24 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 20:37 [PATCH v2] ata: pata_at91.c bugfix for high master clock Igor Plyatov
2010-12-11 22:10 ` Jeff Garzik
2010-12-12 13:49 ` Sergei Shtylyov
2010-12-12 19:02 ` Igor Plyatov
2010-12-13 11:02 ` Sergei Shtylyov
2010-12-24 18:30 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D14E6E2.3080501@pobox.com \
--to=jgarzik@pobox.com \
--cc=christian.glindkamp@taskit.de \
--cc=geomatsi@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=pgsellmann@portner-elektronik.at \
--cc=plyatov@gmail.com \
--cc=ryan@bluewatersys.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox