From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
acme@redhat.com, masami.hiramatsu.pt@hitachi.com,
fbuihuu@gmail.com, tglx@linutronix.de, vagabon.xyz@gmail.com,
mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp
Subject: Re: [tip:perf/core] perf probe: Fix wrong warning in __show_one_line() if read(1) errors happen
Date: Sun, 26 Dec 2010 23:11:19 +0900 [thread overview]
Message-ID: <4D174D07.6030706@hitachi.com> (raw)
In-Reply-To: <tip-32b2b6ec57a3adb3ab7215fbf36ec61c15de06ee@git.kernel.org>
(2010/12/25 17:58), tip-bot for Franck Bui-Huu wrote:
> Commit-ID: 32b2b6ec57a3adb3ab7215fbf36ec61c15de06ee
> Gitweb: http://git.kernel.org/tip/32b2b6ec57a3adb3ab7215fbf36ec61c15de06ee
> Author: Franck Bui-Huu <vagabon.xyz@gmail.com>
> AuthorDate: Wed, 22 Dec 2010 17:37:13 +0100
> Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Wed, 22 Dec 2010 20:32:08 -0200
>
> perf probe: Fix wrong warning in __show_one_line() if read(1) errors happen
>
> This was introduced by commit fde52dbd7f71934aba4e150f3d1d51e826a08850.
>
It's a good fix for me.
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> LKML-Reference: <m3y67hsr0m.fsf@gmail.com>
> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/probe-event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 099336e..4bde988 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -309,7 +309,7 @@ static int __show_one_line(FILE *fp, int l, bool skip, bool show_num)
> return 1;
> error:
> if (ferror(fp)) {
> - pr_warning("Source file is shorter than expected.\n");
> + pr_warning("File read error: %s\n", strerror(errno));
> return -1;
> }
> return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2010-12-26 14:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:17 [PATCH 0/6] Minor cleanups & fixes for perf-probe(1) Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 1/6] perf-tools: make perf-probe -L display the absolute path of the dumped file Franck Bui-Huu
2010-12-21 5:30 ` Masami Hiramatsu
2010-12-22 11:30 ` [tip:perf/core] perf probe: Make " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 2/6] perf-probe: rewrite show_one_line() to make it simpler Franck Bui-Huu
2010-12-21 8:55 ` Masami Hiramatsu
2010-12-22 11:30 ` [tip:perf/core] perf probe: Rewrite " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 3/6] perf-probe: clean up redundant tests in show_line_range() Franck Bui-Huu
2010-12-21 9:47 ` Masami Hiramatsu
2010-12-22 11:31 ` [tip:perf/core] perf probe: Clean " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 4/6] perf-probe: Fix line range description since a single file is allowed Franck Bui-Huu
2010-12-22 11:31 ` [tip:perf/core] perf probe: " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 5/6] perf-probe: don't always consider EOF as an error when listing source code Franck Bui-Huu
2010-12-21 11:54 ` Masami Hiramatsu
2010-12-22 11:31 ` [tip:perf/core] perf probe: Don't " tip-bot for Franck Bui-Huu
2010-12-22 13:14 ` Franck Bui-Huu
2010-12-22 14:43 ` Arnaldo Carvalho de Melo
2010-12-22 16:37 ` Franck Bui-Huu
2010-12-25 8:58 ` [tip:perf/core] perf probe: Fix wrong warning in __show_one_line() if read(1) errors happen tip-bot for Franck Bui-Huu
2010-12-26 14:11 ` Masami Hiramatsu [this message]
2010-12-20 14:18 ` [PATCH 6/6] perf-probe: handle gracefully some stupid and buggy line syntaxes Franck Bui-Huu
2010-12-21 13:10 ` Masami Hiramatsu
2010-12-22 11:32 ` [tip:perf/core] perf probe: Handle " tip-bot for Franck Bui-Huu
2010-12-21 13:11 ` [PATCH 0/6] Minor cleanups & fixes for perf-probe(1) Masami Hiramatsu
2010-12-21 18:01 ` Franck Bui-Huu
2010-12-21 21:05 ` Arnaldo Carvalho de Melo
2010-12-22 13:11 ` Franck Bui-Huu
2010-12-24 0:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D174D07.6030706@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=acme@redhat.com \
--cc=fbuihuu@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox