linux-next: build warning after merge of the Linus' tree

linux-next: build warning after merge of the Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

Hi all,

After merging the Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

drivers/ata/pata_cs5536.c:47:1: warning: "rdmsr" redefined
In file included from arch/x86/include/asm/irqflags.h:60,
                 from include/linux/irqflags.h:15,
                 from arch/x86/include/asm/system.h:11,
                 from arch/x86/include/asm/processor.h:17,
                 from include/linux/prefetch.h:14,
                 from include/linux/list.h:7,
                 from include/linux/module.h:9,
                 from drivers/ata/pata_cs5536.c:33:
arch/x86/include/asm/paravirt.h:146:1: warning: this is the location of the previous definition
drivers/ata/pata_cs5536.c:48:1: warning: "wrmsr" redefined
arch/x86/include/asm/paravirt.h:154:1: warning: this is the location of the previous definition

Caused by commit 9272dcc232b84ccb027d6861077934055d42764d ("pata_cs5536:
Add support for non-X86_32 platforms").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the Linus' tree

[Jeff Garzik]

On 12/26/2010 05:58 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the Linus' tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
>
> drivers/ata/pata_cs5536.c:47:1: warning: "rdmsr" redefined
> In file included from arch/x86/include/asm/irqflags.h:60,
>                   from include/linux/irqflags.h:15,
>                   from arch/x86/include/asm/system.h:11,
>                   from arch/x86/include/asm/processor.h:17,
>                   from include/linux/prefetch.h:14,
>                   from include/linux/list.h:7,
>                   from include/linux/module.h:9,
>                   from drivers/ata/pata_cs5536.c:33:
> arch/x86/include/asm/paravirt.h:146:1: warning: this is the location of the previous definition
> drivers/ata/pata_cs5536.c:48:1: warning: "wrmsr" redefined
> arch/x86/include/asm/paravirt.h:154:1: warning: this is the location of the previous definition
>
> Caused by commit 9272dcc232b84ccb027d6861077934055d42764d ("pata_cs5536:
> Add support for non-X86_32 platforms").

Just sent a fix upstream.

The fix is a bit ugly ("#undef rdmsr" etc.), but that driver does not 
need anything more extensive.

linux-next: build warning after merge of the Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi all,

Building Linus' tree today linux-next (x86_64_allmodconfig)
produced quite a few of these warnings:

include/media/soc_camera.h: In function 'soc_camera_i2c_to_vdev':
include/media/soc_camera.h:257:34: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This was introduced by commit 2f0babb7e432 ("[media] V4L: soc-camera:
make (almost) all client drivers re-usable outside of the framework").

This warning is caused by the "grp_id" member of "struct v4l2_subdev" -
which is a u32 - being cast to a pointer.  That pointer is dereferenced,
so I have no idea how that is supposed to work on any 64 bit platform.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the Linus' tree

[Guennadi Liakhovetski]

Hi Stephen

On Mon, 21 Nov 2011, Stephen Rothwell wrote:

> Hi all,
> 
> Building Linus' tree today linux-next (x86_64_allmodconfig)
> produced quite a few of these warnings:
> 
> include/media/soc_camera.h: In function 'soc_camera_i2c_to_vdev':
> include/media/soc_camera.h:257:34: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 
> This was introduced by commit 2f0babb7e432 ("[media] V4L: soc-camera:
> make (almost) all client drivers re-usable outside of the framework").
> 
> This warning is caused by the "grp_id" member of "struct v4l2_subdev" -
> which is a u32 - being cast to a pointer.  That pointer is dereferenced,
> so I have no idea how that is supposed to work on any 64 bit platform.

soc-camera atm supports 7 platforms (if I haven't forgotten anyone), none 
of them is 64-bit. But you're right, it shall compile cleanly on 64 bits 
too, I'm working on a patch. Unfortunately, while working on it I came 
across other regressions, that blocked my tests... But a solution will be 
found.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/