From: "H. Peter Anvin" <hpa@zytor.com>
To: Tony Luck <tony.luck@intel.com>
Cc: Len Brown <lenb@kernel.org>, Jack Steiner <steiner@sgi.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
gbeshers@sgi.com
Subject: Re: [PATCH] ACPI: use ioremap_cache()
Date: Mon, 27 Dec 2010 12:12:34 -0800 [thread overview]
Message-ID: <4D18F332.5090904@zytor.com> (raw)
In-Reply-To: <AANLkTin7WmYo47JvCMSjExkZ8o2rPajB3fOxU80-UdE1@mail.gmail.com>
On 12/27/2010 11:42 AM, Tony Luck wrote:
> On Fri, Dec 17, 2010 at 12:08 AM, Len Brown <lenb@kernel.org> wrote:
>> No change on ia64.
>
> Apart from breaking the build :-(
>
>> +++ b/arch/ia64/include/asm/io.h
> ...
>> +static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned long size)
>> +{
>> + return ioremap(unsigned long phys_addr, unsigned long size);
>> +}
>
> Cut & paste issue? ... the compiler would be a lot happier
> without the "unsigned long"s in the call to ioremap().
>
LOL...
In the long(er) run it might be worth considering having the same policy
on IA64 as on x86 -- ioremap() meaning ioremap_nocache().
-hpa
next prev parent reply other threads:[~2010-12-27 20:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 22:09 [PATCH] - Mapping ACPI tables as CACHED Jack Steiner
2010-12-14 22:58 ` H. Peter Anvin
2010-12-14 23:22 ` Len Brown
2010-12-15 0:26 ` H. Peter Anvin
2010-12-15 2:27 ` Jack Steiner
2010-12-15 4:17 ` H. Peter Anvin
2010-12-15 0:04 ` Len Brown
2010-12-15 1:18 ` H. Peter Anvin
2010-12-15 2:40 ` Len Brown
2010-12-15 2:41 ` Jack Steiner
2010-12-15 4:03 ` Len Brown
2010-12-15 4:35 ` Len Brown
2010-12-15 6:17 ` H. Peter Anvin
2010-12-15 6:17 ` Milton Miller
2010-12-15 6:29 ` H. Peter Anvin
2010-12-15 16:46 ` Jack Steiner
2010-12-15 21:16 ` Len Brown
2010-12-15 22:18 ` H. Peter Anvin
2010-12-17 2:54 ` Len Brown
2010-12-17 8:08 ` [PATCH] ACPI: use ioremap_cache() Len Brown
2010-12-27 19:42 ` Tony Luck
2010-12-27 20:12 ` H. Peter Anvin [this message]
2010-12-28 3:21 ` Shaohua Li
2010-12-28 3:35 ` H. Peter Anvin
2010-12-28 5:02 ` Shaohua Li
2010-12-28 20:12 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D18F332.5090904@zytor.com \
--to=hpa@zytor.com \
--cc=gbeshers@sgi.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox