From: Nitin Gupta <ngupta@vflare.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg KH <greg@kroah.com>, Pekka Enberg <penberg@cs.helsinki.fi>,
Dennis Jansen <dennis.jansen@web.de>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][zram] Do not check for init flag before starting I/O
Date: Fri, 31 Dec 2010 00:32:41 +0530 [thread overview]
Message-ID: <4D1CD751.4000509@vflare.org> (raw)
In-Reply-To: <AANLkTi=R0sOvSZqu+Va=W2xJMKEw+kJXufuDwNe8o5NL@mail.gmail.com>
On 12/30/2010 10:47 PM, Linus Torvalds wrote:
> On Thu, Dec 30, 2010 at 1:07 AM, Nitin Gupta<ngupta@vflare.org> wrote:
>> zram module is unusable without this fix.
>
> .. and apparently it oopses without it.
>
> See commit 7e24cce38a99f3 which added the code that you now remove.
> You were cc'd on it, I don't think we got any reply to it.
>
This commit shows oops in zram_inc_stat() which does not exist in
staging tree version of zram. Its actually a problem with zram version
as present in project's own repository where we allocate struct
zram_stats_cpu upon device initialization. OTOH, In mainline/staging
version of zram, we allocate struct stats upfront, so this oops cannot
happen in mainline version.
So, this commit is not even applicable for mainline/staging tree. My
bad, I didn't get a chance to review that patch.
> So no. I'm not taking this without way more explanations of why the
> original problem isn't a problem any more.
>
I will now end development on local project repository and sync it with
the mainline version, so all future development happens on
mainline/staging only, avoiding such confusions in future.
Nitin
next prev parent reply other threads:[~2010-12-30 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 9:07 [PATCH][zram] Do not check for init flag before starting I/O Nitin Gupta
2010-12-30 17:17 ` Linus Torvalds
2010-12-30 19:02 ` Nitin Gupta [this message]
2010-12-30 20:09 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1CD751.4000509@vflare.org \
--to=ngupta@vflare.org \
--cc=dennis.jansen@web.de \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox