* [PATCH] speakup: &&/|| confusion in silent_store()
@ 2011-01-01 15:49 roel kluin
0 siblings, 0 replies; only message in thread
From: roel kluin @ 2011-01-01 15:49 UTC (permalink / raw)
To: Andrew Morton, LKML, w.d.hubbs
Fix test: the branch is always taken.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/staging/speakup/kobjects.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index cc79f9e..a082f8d 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -332,7 +332,7 @@ static ssize_t silent_store(struct kobject *kobj, struct kobj_attribute *attr,
unsigned long flags;
len = strlen(buf);
- if (len > 0 || len < 3) {
+ if (len > 0 && len < 3) {
ch = buf[0];
if (ch == '\n')
ch = '0';
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-01 15:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-01 15:49 [PATCH] speakup: &&/|| confusion in silent_store() roel kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox