From: Michal Simek <monstr@monstr.eu>
To: roel kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] microblaze: correct PVR access macros
Date: Mon, 03 Jan 2011 11:13:21 +0100 [thread overview]
Message-ID: <4D21A141.1060801@monstr.eu> (raw)
In-Reply-To: <4D1F61B9.6040900@gmail.com>
roel kluin wrote:
> A definition like:
>
> #define PVR_IS_FULL(pvr) (pvr.pvr[0] & PVR0_PVR_FULL_MASK)
>
> called with PVR_IS_FULL(foo) will be preprocessed to:
>
> (foo.foo[0] & PVR0_PVR_FULL_MASK)
> ^^^
> So to fix this and ensure the preprocessor compiles calls correctly:
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/microblaze/include/asm/pvr.h | 160 ++++++++++++++++++------------------
> 1 files changed, 80 insertions(+), 80 deletions(-)
>
> This was not compile tested.
Applied,
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2011-01-03 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 17:17 [PATCH] microblaze: correct PVR access macros roel kluin
2011-01-03 10:13 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D21A141.1060801@monstr.eu \
--to=monstr@monstr.eu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox