public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, "Siddha,
	Suresh B" <suresh.b.siddha@intel.com>,
	Venkatesh Pallipadi <venki@google.com>
Subject: Re: Loss of PAT-WC after resume on i5
Date: Mon, 03 Jan 2011 08:01:05 -0800	[thread overview]
Message-ID: <4D21F2C1.30500@zytor.com> (raw)
In-Reply-To: <849307$b076ne@azsmga001.ch.intel.com>

On 01/03/2011 04:14 AM, Chris Wilson wrote:
> We have noticed that graphics may become very slow after suspend & resume.
> One effect that we have clearly identified is that writing through the GTT
> becomes very slow:
> 
> Before suspending:
>   Time to pwrite 16k through the CPU:               4µs
>   Time to read 16k through a GTT map:             901µs
>   Time to write 16k through a GTT map:             23µs
>   Time to read 16k (again) through a GTT map:     900µs
>   Time to pwrite 16k through the GTT:               7µs
> 
> After resume:
>   Time to pwrite 16k through the CPU:               4µs
>   Time to read 16k through a GTT map:             900µs
>   Time to write 16k through a GTT map:            876µs
>   Time to read 16k (again) through a GTT map:     899µs
>   Time to pwrite 16k through the GTT:             431µs
> 
> Presuming that it was the loss of the WC mapping, I tore down and
> recreated the ioremap_wc upon resume which restored performance back to
> normal.
> 
> So could we indeed be failing to restore the PAT caching state upon
> resume?
> 

Sounds like it.  It sounds based on your description that it's something
more fundamental than just the state of the PAT MSR being lost, too,
although perhaps that's the first thing to check...

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


       reply	other threads:[~2011-01-03 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <849307$b076ne@azsmga001.ch.intel.com>
2011-01-03 16:01 ` H. Peter Anvin [this message]
2011-01-03 16:21   ` Loss of PAT-WC after resume on i5 Chris Wilson
2011-01-03 17:29     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D21F2C1.30500@zytor.com \
    --to=hpa@zytor.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox