From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "ext tapio.vihuri@nokia.com" <tapio.vihuri@nokia.com>
Cc: dmitry.torokhov@gmail.com, randy.dunlap@oracle.com,
alsa-devel@alsa-project.org, ilkka.koskinen@nokia.com,
linux-kernel@vger.kernel.org, samu.p.onkalo@nokia.com
Subject: Re: [alsa-devel] [PATCH v3 2/3] ECI: introducing ECI bus driver
Date: Wed, 05 Jan 2011 10:21:07 +0200 [thread overview]
Message-ID: <4D2429F3.80004@nokia.com> (raw)
In-Reply-To: <1294149748-13854-3-git-send-email-tapio.vihuri@nokia.com>
Hi,
On 01/04/11 16:02, ext tapio.vihuri@nokia.com wrote:
> From: Tapio Vihuri <tapio.vihuri@nokia.com>
>
> ECI bus controller is kind of bridge between host CPU I2C and ECI accessory
> ECI communication.
There seams to be no change between v2 and v3 in regards to this micro
controller driver, so my comments on the v2 applies here as well.
Would you rename the driver (to something other than ecibus)?
If the intention is to make this driver only work on Intel's Moorestown
platform, then be it, but you should mention it explicitly in the
Kconfig, and the driver name shall reflect the same as well.
My comments on the intel specific intel_scu_ipc_iowrite8, and the i2c
part still holds.
Thanks,
Péter
prev parent reply other threads:[~2011-01-05 8:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 14:02 [PATCH v3 0/3] input: Add support for ECI (multimedia) accessories tapio.vihuri
2011-01-04 14:02 ` [PATCH v3 1/3] ECI: input: introduce ECI accessory input driver tapio.vihuri
2011-01-04 14:02 ` [PATCH v3 2/3] ECI: introducing ECI bus driver tapio.vihuri
2011-01-04 14:02 ` [PATCH v3 3/3] ECI: adding platform data for ECI driver tapio.vihuri
2011-01-05 8:21 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2429F3.80004@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=samu.p.onkalo@nokia.com \
--cc=tapio.vihuri@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox