From: David Daney <ddaney@caviumnetworks.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 2/6] MIPS: pfn_valid() is broken on low memory HIGHMEM systems
Date: Thu, 06 Jan 2011 09:36:35 -0800 [thread overview]
Message-ID: <4D25FDA3.5000807@caviumnetworks.com> (raw)
In-Reply-To: <b2191149ada0fd929b3818c51298ae8d@localhost>
On 01/05/2011 11:31 PM, Kevin Cernekee wrote:
[...]
> diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c
> index 2efcbd2..18183a4 100644
> --- a/arch/mips/mm/init.c
> +++ b/arch/mips/mm/init.c
> @@ -370,7 +370,7 @@ void __init mem_init(void)
> #ifdef CONFIG_DISCONTIGMEM
> #error "CONFIG_HIGHMEM and CONFIG_DISCONTIGMEM dont work together yet"
> #endif
> - max_mapnr = highend_pfn;
> + max_mapnr = highend_pfn ? : max_low_pfn;
That is not standard C.
How about: max_mapnr = highend_pfn ? highend_pfn : max_low_pfn;
David Daney
next prev parent reply other threads:[~2011-01-06 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 7:31 [PATCH RESEND 1/6] MIPS: sync after cacheflush Kevin Cernekee
2011-01-06 7:31 ` [PATCH RESEND 2/6] MIPS: pfn_valid() is broken on low memory HIGHMEM systems Kevin Cernekee
2011-01-06 17:36 ` David Daney [this message]
2011-01-06 7:31 ` [PATCH v2 RESEND 3/6] MIPS: Move FIXADDR_TOP into spaces.h Kevin Cernekee
2011-01-06 7:31 ` [PATCH v4 RESEND 4/6] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors Kevin Cernekee
2011-01-06 7:31 ` [PATCH RESEND 5/6] MIPS: Install handlers for BMIPS software IRQs Kevin Cernekee
2011-01-06 7:31 ` [PATCH 6/6] MIPS: Limit fixrange_init() to the FIXMAP region Kevin Cernekee
2011-05-19 13:03 ` Ralf Baechle
2011-01-06 16:17 ` [PATCH RESEND 1/6] MIPS: sync after cacheflush Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25FDA3.5000807@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox