Re: [RESEND #2] [PATCH v2] LEDS: Add output invertion option to backlight trigger

Andrew Morton
2011-01-06T21:17:42Z

On Thu, 6 Jan 2011 13:08:56 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Thu, 6 Jan 2011 13:04:40 -0800 Andrew Morton wrote:
>
> > On Thu, 9 Dec 2010 14:41:50 +0100
> > Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> >
> > > +static DEVICE_ATTR(invert, 0644, bl_trig_invert_show, bl_trig_invert_store);
> >
> > This new sysfs file should be documented. Where would be an
> > appropriate place for that? Documentation/leds-class.txt doesn't
> > mention a sysfs API at all.
> > --
>
> in Documentation/ABI/, where all sysfs interface info lives.
>

Spose so. Documentation/ABI/stable/sysfs-class-backlight does have
some stuff in it.

Personally I tend to regard Documentation/ABI/ as fairly useless
incomprehensible stuff, maintained to keep Greg happy ;) It'd be better
to have a nice little well-maintained document for a subsystem such as
this which actually explains its operation in a useful-to-humans way.
Rather than just mechanically filling out forms.

But a Documentation/ABI update is a heck of a lot better than nothing.