Re: [PATCH] apparmor: cleanup generated files correctly

[John Johansen <john.johansen@canonical.com>]

On 01/07/2011 06:14 AM, Michal Hocko wrote:
> Hi John,
> could you consider the patch bellow. The issue is minor but I guess it
> is worth having fixed.
certainly thanks for the fix, I'll pull into the AA tree and push up with
a couple of other fixes I have pending

Acked-by: John Johansen <john.johansen@canonical.com>

> ---
> From a6b164aeff1234708595d06dd6f9abeb59564da6 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.cz>
> Date: Fri, 7 Jan 2011 15:03:02 +0100
> Subject: [PATCH] apparmor: cleanup generated files correctly
> 
> clean-files should be defined as a variable not a target.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
>  security/apparmor/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/apparmor/Makefile b/security/apparmor/Makefile
> index f204869..bbb942a 100644
> --- a/security/apparmor/Makefile
> +++ b/security/apparmor/Makefile
> @@ -6,7 +6,7 @@ apparmor-y := apparmorfs.o audit.o capability.o context.o ipc.o lib.o match.o \
>                path.o domain.o policy.o policy_unpack.o procattr.o lsm.o \
>                resource.o sid.o file.o
>  
> -clean-files: capability_names.h af_names.h
> +clean-files := capability_names.h af_names.h
>  
>  quiet_cmd_make-caps = GEN     $@
>  cmd_make-caps = echo "static const char *capability_names[] = {" > $@ ; sed -n -e "/CAP_FS_MASK/d" -e "s/^\#define[ \\t]\\+CAP_\\([A-Z0-9_]\\+\\)[ \\t]\\+\\([0-9]\\+\\)\$$/[\\2]  = \"\\1\",/p" $< | tr A-Z a-z >> $@ ; echo "};" >> $@