From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823Ab1AJGqU (ORCPT ); Mon, 10 Jan 2011 01:46:20 -0500 Received: from freeflow.nu ([178.79.134.28]:38174 "EHLO freeflow.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066Ab1AJGqS (ORCPT ); Mon, 10 Jan 2011 01:46:18 -0500 Message-ID: <4D2AAB3C.1080009@kernel.org> Date: Mon, 10 Jan 2011 08:46:20 +0200 From: Pekka Enberg User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Michael Cree CC: Randy Dunlap , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, Matt Turner , Tejun Heo , Andrew Morton , Bob Tracy , David Woodhouse Subject: Re: [PATCH] i2c-i801: Add missing include. References: <20110104141151.b6035bf3.randy.dunlap@oracle.com> <1294634675-29557-1-git-send-email-mcree@orcon.net.nz> In-Reply-To: <1294634675-29557-1-git-send-email-mcree@orcon.net.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/11 6:44 AM, Michael Cree wrote: > Causes compile error on Alpha, but not on x86 because its version > of includes. In any case, it's a bug > in the driver. > > Signed-off-by: Michael Cree Acked-by: Pekka Enberg > --- > > Since no one else has submitted the patch here it goes. Shall I send it > directly to Linus (since I plan to send some Alpha specific patches very > soon) or will the subsytem maintainers pick it up? I'd let Andrew sort it out. (hi Andrew! ;-) > drivers/i2c/busses/i2c-i801.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 02835ce..7979aef 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -72,6 +72,7 @@ > #include > #include > #include > +#include > > /* I801 SMBus address offsets */ > #define SMBHSTSTS(p) (0 + (p)->smba)