* [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
@ 2011-01-04 6:18 Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Bob Tracy @ 2011-01-04 6:18 UTC (permalink / raw)
To: linux-kernel, linux-alpha; +Cc: mcree
Another 2.6.37-rc8 build failure on alpha:
(...)
CC [M] drivers/i2c/busses/i2c-i801.o
drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
make: *** [drivers] Error 2
--Bob
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
@ 2011-01-04 7:15 ` Pekka Enberg
2011-01-04 19:37 ` Matt Turner
2011-01-04 21:10 ` Maciej Rutecki
2 siblings, 0 replies; 10+ messages in thread
From: Pekka Enberg @ 2011-01-04 7:15 UTC (permalink / raw)
To: Bob Tracy; +Cc: linux-kernel, linux-alpha, mcree
On Tue, Jan 4, 2011 at 8:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
> Another 2.6.37-rc8 build failure on alpha:
>
> (...)
> CC [M] drivers/i2c/busses/i2c-i801.o
> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
Adding a
#include <linux/slab.h>
in drivers/i2c/busses/i2c-i801.c should help. Care to send a tested
patch to do that?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
@ 2011-01-04 19:37 ` Matt Turner
2011-01-04 20:56 ` Pekka Enberg
2011-01-04 22:04 ` [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 21:10 ` Maciej Rutecki
2 siblings, 2 replies; 10+ messages in thread
From: Matt Turner @ 2011-01-04 19:37 UTC (permalink / raw)
To: Bob Tracy; +Cc: linux-kernel, linux-alpha, mcree
On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
> Another 2.6.37-rc8 build failure on alpha:
>
> (...)
> CC [M] drivers/i2c/busses/i2c-i801.o
> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
>
> --Bob
Is this specific to alpha? I wonder why we don't see this on other platforms?
Thanks Bob,
Matt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 19:37 ` Matt Turner
@ 2011-01-04 20:56 ` Pekka Enberg
2011-01-04 22:11 ` Randy Dunlap
2011-01-04 22:04 ` [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
1 sibling, 1 reply; 10+ messages in thread
From: Pekka Enberg @ 2011-01-04 20:56 UTC (permalink / raw)
To: Matt Turner
Cc: Bob Tracy, linux-kernel, linux-alpha, mcree, Tejun Heo,
Andrew Morton
On Tue, Jan 4, 2011 at 9:37 PM, Matt Turner <mattst88@gmail.com> wrote:
> On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
>> Another 2.6.37-rc8 build failure on alpha:
>>
>> (...)
>> CC [M] drivers/i2c/busses/i2c-i801.o
>> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
>> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
>> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
>> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
>> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
>> make[2]: *** [drivers/i2c/busses] Error 2
>> make[1]: *** [drivers/i2c] Error 2
>> make: *** [drivers] Error 2
>>
>> --Bob
>
> Is this specific to alpha? I wonder why we don't see this on other platforms?
The x86 version of <asm/pci.h> includes <linux/slab.h> which hides the
problem on x86 at least. There was a big cleanup of implicit
<linux/slab.h> inclusions few months ago which has exposed the
problem.
It's a bug in the driver, just add the include there.
Pekka
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 20:56 ` Pekka Enberg
@ 2011-01-04 22:11 ` Randy Dunlap
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
0 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2011-01-04 22:11 UTC (permalink / raw)
To: Pekka Enberg
Cc: Matt Turner, Bob Tracy, linux-kernel, linux-alpha, mcree,
Tejun Heo, Andrew Morton
On Tue, 4 Jan 2011 22:56:18 +0200 Pekka Enberg wrote:
> On Tue, Jan 4, 2011 at 9:37 PM, Matt Turner <mattst88@gmail.com> wrote:
> > On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
> >> Another 2.6.37-rc8 build failure on alpha:
> >>
> >> (...)
> >> CC [M] drivers/i2c/busses/i2c-i801.o
> >> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> >> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> >> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> >> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> >> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> >> make[2]: *** [drivers/i2c/busses] Error 2
> >> make[1]: *** [drivers/i2c] Error 2
> >> make: *** [drivers] Error 2
> >>
> >> --Bob
> >
> > Is this specific to alpha? I wonder why we don't see this on other platforms?
>
> The x86 version of <asm/pci.h> includes <linux/slab.h> which hides the
> problem on x86 at least. There was a big cleanup of implicit
> <linux/slab.h> inclusions few months ago which has exposed the
> problem.
>
> It's a bug in the driver, just add the include there.
exactly.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] i2c-i801: Add missing <linux/slab.h> include.
2011-01-04 22:11 ` Randy Dunlap
@ 2011-01-10 4:44 ` Michael Cree
2011-01-10 6:46 ` Pekka Enberg
2011-01-10 14:03 ` Bob Tracy
0 siblings, 2 replies; 10+ messages in thread
From: Michael Cree @ 2011-01-10 4:44 UTC (permalink / raw)
To: Randy Dunlap
Cc: Michael Cree, linux-kernel, linux-alpha, Matt Turner, Tejun Heo,
Andrew Morton, Bob Tracy, Pekka Enberg, David Woodhouse
Causes compile error on Alpha, but not on x86 because its version
of <asm/pci.h> includes <linux/slab.h>. In any case, it's a bug
in the driver.
Signed-off-by: Michael Cree <mcree@orcon.net.nz>
---
Since no one else has submitted the patch here it goes. Shall I send it
directly to Linus (since I plan to send some Alpha specific patches very
soon) or will the subsytem maintainers pick it up?
drivers/i2c/busses/i2c-i801.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 02835ce..7979aef 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -72,6 +72,7 @@
#include <linux/acpi.h>
#include <linux/io.h>
#include <linux/dmi.h>
+#include <linux/slab.h>
/* I801 SMBus address offsets */
#define SMBHSTSTS(p) (0 + (p)->smba)
--
1.7.2.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c-i801: Add missing <linux/slab.h> include.
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
@ 2011-01-10 6:46 ` Pekka Enberg
2011-01-10 14:03 ` Bob Tracy
1 sibling, 0 replies; 10+ messages in thread
From: Pekka Enberg @ 2011-01-10 6:46 UTC (permalink / raw)
To: Michael Cree
Cc: Randy Dunlap, linux-kernel, linux-alpha, Matt Turner, Tejun Heo,
Andrew Morton, Bob Tracy, David Woodhouse
On 1/10/11 6:44 AM, Michael Cree wrote:
> Causes compile error on Alpha, but not on x86 because its version
> of<asm/pci.h> includes<linux/slab.h>. In any case, it's a bug
> in the driver.
>
> Signed-off-by: Michael Cree<mcree@orcon.net.nz>
Acked-by: Pekka Enberg <penberg@kernel.org>
> ---
>
> Since no one else has submitted the patch here it goes. Shall I send it
> directly to Linus (since I plan to send some Alpha specific patches very
> soon) or will the subsytem maintainers pick it up?
I'd let Andrew sort it out. (hi Andrew! ;-)
> drivers/i2c/busses/i2c-i801.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 02835ce..7979aef 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -72,6 +72,7 @@
> #include<linux/acpi.h>
> #include<linux/io.h>
> #include<linux/dmi.h>
> +#include<linux/slab.h>
>
> /* I801 SMBus address offsets */
> #define SMBHSTSTS(p) (0 + (p)->smba)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c-i801: Add missing <linux/slab.h> include.
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
2011-01-10 6:46 ` Pekka Enberg
@ 2011-01-10 14:03 ` Bob Tracy
1 sibling, 0 replies; 10+ messages in thread
From: Bob Tracy @ 2011-01-10 14:03 UTC (permalink / raw)
To: Michael Cree
Cc: Randy Dunlap, linux-kernel, linux-alpha, Matt Turner, Tejun Heo,
Andrew Morton, Pekka Enberg, David Woodhouse
On Mon, Jan 10, 2011 at 05:44:35PM +1300, Michael Cree wrote:
> Causes compile error on Alpha, but not on x86 because its version
> of <asm/pci.h> includes <linux/slab.h>. In any case, it's a bug
> in the driver.
>
> Signed-off-by: Michael Cree <mcree@orcon.net.nz>
ACK. Works for me.
--Bob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 19:37 ` Matt Turner
2011-01-04 20:56 ` Pekka Enberg
@ 2011-01-04 22:04 ` Bob Tracy
1 sibling, 0 replies; 10+ messages in thread
From: Bob Tracy @ 2011-01-04 22:04 UTC (permalink / raw)
To: Matt Turner; +Cc: linux-kernel, linux-alpha, mcree
On Tue, Jan 04, 2011 at 02:37:00PM -0500, Matt Turner wrote:
> On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
> > Another 2.6.37-rc8 build failure on alpha:
> >
> > (...)
> > ?CC [M] ?drivers/i2c/busses/i2c-i801.o
> > drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> > drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> > drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> > drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> > make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> > make[2]: *** [drivers/i2c/busses] Error 2
> > make[1]: *** [drivers/i2c] Error 2
> > make: *** [drivers] Error 2
>
> Is this specific to alpha? I wonder why we don't see this on other platforms?
I'll start the Intel build this evening to check, but I'd be willing to
bet it's Alpha-specific (only because no one else has hollered).
--Bob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
2011-01-04 19:37 ` Matt Turner
@ 2011-01-04 21:10 ` Maciej Rutecki
2 siblings, 0 replies; 10+ messages in thread
From: Maciej Rutecki @ 2011-01-04 21:10 UTC (permalink / raw)
To: Bob Tracy; +Cc: linux-kernel, linux-alpha, mcree
I created a Bugzilla entry at
https://bugzilla.kernel.org/show_bug.cgi?id=26132
for your bug report, please add your address to the CC list in there, thanks!
On wtorek, 4 stycznia 2011 o 07:18:21 Bob Tracy wrote:
> Another 2.6.37-rc8 build failure on alpha:
>
> (...)
> CC [M] drivers/i2c/busses/i2c-i801.o
> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function
> 'kzalloc' drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes
> pointer from integer without a cast drivers/i2c/busses/i2c-i801.c:855:
> error: implicit declaration of function 'kfree' make[3]: ***
> [drivers/i2c/busses/i2c-i801.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
>
> --Bob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-01-10 14:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
2011-01-04 19:37 ` Matt Turner
2011-01-04 20:56 ` Pekka Enberg
2011-01-04 22:11 ` Randy Dunlap
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
2011-01-10 6:46 ` Pekka Enberg
2011-01-10 14:03 ` Bob Tracy
2011-01-04 22:04 ` [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 21:10 ` Maciej Rutecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox