Re: [PATCH 1/3] pci, usb: Seperate usb handoff func to another file

Benjamin Herrenschmidt
2011-01-10T09:40:05Z

On Sun, 2011-01-09 at 23:01 -0800, Yinghai Lu wrote:
> On 01/09/2011 01:09 PM, Benjamin Herrenschmidt wrote:
> > acceptable ?
> >
> > I think if you want to make the handoff happen -that- early, you have
> > basically two options. One is to move it all to arch code, and the other
> > one is to create early-boot "fake" struct pci_dev & bus that have the
> > config callbacks implemented pointing to the early stuff. You can do
> > that entirely within your arch code, and avoids most of the grossness
> > above in the generic places.
>
> good idea, will make one get_early_pci_dev() for x86 as dummy device.
>
> >
> > It would avoid that turd too:
> >
> >> +#include "usb_handoff.c"
>
> may still need that to avoid some MMIO bar finding and remapping etc.

Might be better to test for system state... a bit ugly too but less than
#include'ing the C file.

Cheers,
Ben.