Re: [PATCH 3/3] x86: usb handoff in early_quirk

Greg KH
2011-01-10T16:05:30Z

On Sun, Jan 09, 2011 at 11:59:56AM -0800, Yinghai Lu wrote:
>
> some systems keep getting
> APIC calibration not consistent with PM-Timer: 139ms instead of 100ms
> APIC delta adjusted to PM-Timer: 831249 (1163736)
>
> USB legacy SMI handler is not disabled at that time.
>
> Try to disable USB legacy support early with this patch.
> So later APIC Timer calibration don't get messed up by USB legacy support SMI handler.
> After this patch, that warning never show up for 100 reboot tests.

But is that warning a real issue? Does it cause problems for the user
(becides annoying them of course)?

> reuse code from drivers/usb/host/pci-quirks.c
> with changes
> 1. delay and sleep ===> io_delay
> 2. dev_warn etc to pr_warn(num, slot, func...)

Why change this function? What's wrong with dev_warn()? It's much more
descriptive of the device that is being referred to.

thanks,

greg k-h