Re: perf: commit 55b4462 causes perf record to hang

Arnaldo Carvalho de Melo
2011-01-11T11:35:12Z

Em Tue, Jan 11, 2011 at 09:28:25AM +0100, Thomas Gleixner escreveu:
> On Mon, 10 Jan 2011, Arnaldo Carvalho de Melo wrote:
> > Can you try with this patch, not reverting tglx's patch?
> >
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 6fb4694..313dac2 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1007,7 +1007,7 @@ more:
> > if (size == 0)
> > size = 8;
> >
> > - if (head + event->header.size >= mmap_size) {
> > + if (head + event->header.size > mmap_size) {
> > if (mmaps[map_idx]) {
> > munmap(mmaps[map_idx], mmap_size);
> > mmaps[map_idx] = NULL;
> >
>
> /me feels stupid

I feel like that sometimes too, probably more often than you :-P

- Arnaldo