From: Mourad De Clerck <mourad@aquazul.com>
To: Richard Hughes <hughsient@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
Andrew Morton <akpm@linux-foundation.org>,
Richard Purdie <rpurdie@linux.intel.com>,
linux-kernel@vger.kernel.org,
Richard Hughes <richard@hughsie.com>
Subject: Re: mbp_nvidia_bl: Remove DMI dependency
Date: Tue, 11 Jan 2011 19:07:14 +0100 [thread overview]
Message-ID: <4D2C9C52.1000304@aquazul.com> (raw)
In-Reply-To: <AANLkTinovDucigOX+kidh+KwekbZP65moy7P2pYNn25L@mail.gmail.com>
On 11/01/11 18:05, Richard Hughes wrote:
>>> The only slight change is that gnome-power-manager needs to be updated
>>> to use /sys/class/backlight/apple_backlight instead of mbp_backlight.
>>
>> gnome-power-manager needs not to have a hardcoded list of backlights.
>
> Mourad, how many devices do you have in /sys/class/backlight?
I have two: nv_backlight and mbp_backlight (now apple_backlight). The
trouble is that nouveau's nv_backlight is broken on my hardware (NVAF).
(I think it's this issue:
https://bugzilla.redhat.com/show_bug.cgi?id=625171 - max_brightness is
wrong)
When I remove nv_backlight completely and just have apple_backlight,
g-p-m works properly. When they're both there, g-p-m prefers nv_backlight.
-- Mourad
prev parent reply other threads:[~2011-01-11 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 8:49 [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1 Mourad De Clerck
2011-01-04 22:36 ` Andrew Morton
2011-01-11 16:42 ` mbp_nvidia_bl: Remove DMI dependency (was: Re: [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1) Mourad De Clerck
2011-01-11 16:48 ` Matthew Garrett
2011-01-11 17:05 ` Richard Hughes
2011-01-11 18:07 ` Mourad De Clerck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C9C52.1000304@aquazul.com \
--to=mourad@aquazul.com \
--cc=akpm@linux-foundation.org \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=richard@hughsie.com \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox