From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756483Ab1ALVIV (ORCPT ); Wed, 12 Jan 2011 16:08:21 -0500 Received: from mail.us.es ([193.147.175.20]:32961 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756329Ab1ALVIS (ORCPT ); Wed, 12 Jan 2011 16:08:18 -0500 Message-ID: <4D2E183C.4070908@netfilter.org> Date: Wed, 12 Jan 2011 22:08:12 +0100 From: Pablo Neira Ayuso User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100619 Icedove/3.0.5 MIME-Version: 1.0 To: Jan Engelhardt CC: Valdis.Kletnieks@vt.edu, Patrick McHardy , "David S. Miller" , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: XT_MATCH_REALM Kconfig whinge... References: <20519.1294859715@localhost> <4D2E057D.30707@netfilter.org> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/mixed; boundary="------------010208050509060702040002" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------010208050509060702040002 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 12/01/11 21:57, Jan Engelhardt wrote: > On Wednesday 2011-01-12 20:48, Pablo Neira Ayuso wrote: > >> On 12/01/11 20:15, Valdis.Kletnieks@vt.edu wrote: >>> scripts/kconfig/conf --silentoldconfig Kconfig >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >> >> Does this fix your problem? >> > > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > index 1534f2b..ae56764 100644 > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -886,7 +886,8 @@ config NETFILTER_XT_MATCH_RATEEST > config NETFILTER_XT_MATCH_REALM > tristate '"realm" match support' > depends on NETFILTER_ADVANCED > - select NET_CLS_ROUTE > + depends on NET_SCHED > + depends on NET_CLS_ROUTE > help > This option adds a `realm' match, which allows you to use the realm > key from the routing subsystem inside iptables. > > > This patch is not right. The select should just be removed, because > xt_realm is useful even without SCHED and CLS_ROUTE. I wonder why NET_CLS_ROUTE has been there as dependency. Then this patch should be fine. --------------010208050509060702040002 Content-Type: text/x-patch; name="realm.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="realm.patch" netfilter: xt_realm: fix unmet direct dependencies From: Pablo Neira Ayuso scripts/kconfig/conf --silentoldconfig Kconfig warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) Jan Engelhardt spotted that NET_CLS_ROUTE is a superfluous dependency, for that reason, this patch remove it. Reported by: Valdis Kletnieks Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 1534f2b..8960260 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -886,7 +886,6 @@ config NETFILTER_XT_MATCH_RATEEST config NETFILTER_XT_MATCH_REALM tristate '"realm" match support' depends on NETFILTER_ADVANCED - select NET_CLS_ROUTE help This option adds a `realm' match, which allows you to use the realm key from the routing subsystem inside iptables. --------------010208050509060702040002--