From: Milan Broz <mbroz@redhat.com>
To: Alasdair G Kergon <agk@redhat.com>, Tejun Heo <tj@kernel.org>,
Jens Axboe <jaxboe@fusionio.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] core block bits for 2.6.38
Date: Thu, 13 Jan 2011 22:54:56 +0100 [thread overview]
Message-ID: <4D2F74B0.6030206@redhat.com> (raw)
In-Reply-To: <20110113214308.GA18104@agk-dp.fab.redhat.com>
On 01/13/2011 10:43 PM, Alasdair G Kergon wrote:
> On Thu, Jan 13, 2011 at 09:05:40PM +0100, Tejun Heo wrote:
>> On Thu, Jan 13, 2011 at 8:32 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>>> I see Tejun already posted a fix, but Milan says it does not work.
>>> Tejun, any updates?
>>
>> Hmmm... seems like I missed something. Unfortunately, it's already a
>> bit too late here. I'll get back to it tomorrow afternoon. The issue
>> is mostly cosmetic so if it can wait a day or two I don't think
>> reverting is necessary.
>
> It's only cosmetic if your system is not relying upon userspace programs
> that rely upon it:) My vote would be for reverting the patch for now
> so we can be sure the existing userspace functionality continues to work
> in -rc1.
It is not cosmetic, it breaks core lvm functionality, see my lvresize test case
in the reporting thread. Sorry, but this should be fixed soon or reverted...
http://article.gmane.org/gmane.linux.raid/31164
I thought it is just warning but when testing the fix it shows that
the problem is worse than warning.
Milan
next prev parent reply other threads:[~2011-01-13 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 13:52 [GIT PULL] core block bits for 2.6.38 Jens Axboe
2011-01-13 19:21 ` Alasdair G Kergon
2011-01-13 19:26 ` Linus Torvalds
2011-01-13 19:32 ` Jens Axboe
2011-01-13 20:05 ` Tejun Heo
2011-01-13 21:43 ` Alasdair G Kergon
2011-01-13 21:54 ` Milan Broz [this message]
2011-01-13 19:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F74B0.6030206@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox