From: Li Zefan <lizf@cn.fujitsu.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Nick Piggin <npiggin@gmail.com>, Paul Menage <menage@google.com>,
LKML <linux-kernel@vger.kernel.org>,
containers@lists.linux-foundation.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: kernel BUG at fs/dcache.c:1363 (from cgroup)
Date: Fri, 14 Jan 2011 13:29:34 +0800 [thread overview]
Message-ID: <4D2FDF3E.5030309@cn.fujitsu.com> (raw)
In-Reply-To: <20110114051453.GY19804@ZenIV.linux.org.uk>
Al Viro wrote:
> On Fri, Jan 14, 2011 at 12:56:17PM +0800, Li Zefan wrote:
>> Just mount the cgroupfs:
>>
>> # mount -t cgroup -o cpuset xxx /mnt
>> (oops!!)
>>
>> The bug is caused by:
>>
>> =========
>> commit 0df6a63f8735a7c8a877878bc215d4312e41ef81
>> Author: Al Viro <viro@zeniv.linux.org.uk>
>> Date: Tue Dec 21 13:29:29 2010 -0500
>>
>> switch cgroup
>>
>> switching it to s_d_op allows to kill the cgroup_lookup() kludge.
>>
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> =========
>>
>> This line:
>>
>> + sb->s_d_op = &cgroup_dops;
>
> Oh, crap... Right, it's using simple_lookup(). Let me check if anything
> else might be stepping on that.
>
> Umm... There's a very strange codepath in btrfs that also might.
> Interesting. Fix for cgroup, AFAICS, should be this:
>
patch tested. thanks!
prev parent reply other threads:[~2011-01-14 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 4:56 kernel BUG at fs/dcache.c:1363 (from cgroup) Li Zefan
2011-01-14 5:14 ` Al Viro
2011-01-14 5:29 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2FDF3E.5030309@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=npiggin@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox