From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580Ab1ANVJd (ORCPT ); Fri, 14 Jan 2011 16:09:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38727 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393Ab1ANVJb (ORCPT ); Fri, 14 Jan 2011 16:09:31 -0500 Message-ID: <4D30BB78.5020101@redhat.com> Date: Fri, 14 Jan 2011 22:09:12 +0100 From: Milan Broz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101213 Thunderbird/3.1.7 MIME-Version: 1.0 To: Tejun Heo CC: "Jun'ichi Nomura" , Jens Axboe , Valdis.Kletnieks@vt.edu, Alexander Viro , Neil Brown , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, device-mapper development , Kay Sievers , Alasdair G Kergon Subject: Re: [PATCH UPDATED] block: restore multiple bd_link_disk_holder() support References: <16069.1294853673@localhost> <4D2E4611.90002@redhat.com> <4D2E6129.8000700@ce.jp.nec.com> <20110113172133.GE14096@htj.dyndns.org> <4D2F4799.5030901@redhat.com> <4D2FFBED.6010406@ce.jp.nec.com> <20110114161043.GB978@htj.dyndns.org> In-Reply-To: <20110114161043.GB978@htj.dyndns.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2011 05:10 PM, Tejun Heo wrote: > Commit e09b457b (block: simplify holder symlink handling) incorrectly > assumed that there is only one link at maximum. dm may use multiple > links and expects block layer to track reference count for each link, > which is different from and unrelated to the exclusive device holder > identified by @holder when the device is opened. > > Remove the single holder assumption and automatic removal of the link > and revive the per-link reference count tracking. The code > essentially behaves the same as before commit e09b457b sans the > unnecessary kobject reference count dancing. > > While at it, note that this facility should not be used by anyone else > than the current ones. Sysfs symlinks shouldn't be abused like this > and the whole thing doesn't belong in the block layer at all. > > Signed-off-by: Tejun Heo > Reported-by: Milan Broz > Cc: Jun'ichi Nomura > Cc: Neil Brown > Cc: linux-raid@vger.kernel.org > Cc: Kay Sievers > --- > Thanks for the test commands. They were very helpful. Can you please > test this one? Hi, yes, this one works for me. I run full lvm2 testsuite and no warnings. Thanks! Tested-by: Milan Broz Milan