Re: [PATCH] param: add null statement to compiled-in module params

[Linus Walleij <linus.walleij@stericsson.com>]

On 01/17/2011 12:41 AM, Rusty Russell wrote:
> On Wed, 5 Jan 2011 10:57:04 pm Linus Walleij wrote:
>    
>> Add an unused struct declaration statement requiring a
>> terminating semicolon to the compile-in case to provoke an
>> error if __MODULE_INFO() is used without the terminating
>> semicolon. Previously MODULE_ALIAS("foo") (no semicolon)
>> compiled fine if MODULE was not selected.
>>      
> I really prefer the other way; make everyone use a semicolon.
>    

That's what it does. Currently the kernel allows you to
write MODULE_ALIAS("bar") sans semicolon if you
compile in the module statically...

Or am I getting things wrong?

> Let's look how many we're talking about... hmm, I'm having
> trouble finding any!
>    

There is no module in the kernel doing this, but I
had the issue in the merge window (and fixed it up),
this is to help developers not doing that mistake
again.

> Could you patch this the other way, to make MODULE_ALIAS w/o a
> semicolon always an error?
>    

This is what the patch does... after the patch the
MODULE_ALIAS("foo") without semicolon will throw
a compilation error also on statically linked modules.

Currently it doesn't...

Yours,
Linus Walleij