Re: [PATCH -perf/perf/core 5/6] perf probe: Add variable filter support

Masami Hiramatsu
2011-01-14T02:42:17Z

(2011/01/14 6:18), Franck Bui-Huu wrote:
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> writes:
>
>> Add filters support for available variable list.
>> Default filter is "!__k???tab_*&!__crc_*" for
>> filtering out automatically generated symbols.
>>
>> The format of filter rule is "[!]GLOBPATTERN", so
>> you can use wild cards. If the filter rule starts with
>> '!', matched variables are filter out.
>>
>> e.g.)
>> # perf probe -V schedule --externs --filter=cpu*
>
> I'm wondering if the different syntax below could be simpler:
>
> $ perf probe add <probe>
> $ perf probe del <probe>
> $ perf probe show
>
> $ perf probe list <line>
> ... --vars[=<pattern>] [--externs] <probe>
> ... --funcs[=<pattern>]

Hm, well, if no one complains about changing the syntax
of perf probe, it may make things simple (maybe we'll also
have to drop "perf probe <PROBE>" syntax). Nowadays
we already have perf-kvm, perf-sched, etc. which use sub-sub
commands.

IMHO, for avoiding confusion old options and "perf-list", below
sub-sub commands are more suitable.

$ perf probe add <probe>
$ perf probe del <probe>
$ perf probe list
$ perf probe lines <line>
$ perf probe vars [--filter=<pattern>|-F <pattern>] [--extern] <probe>
$ perf probe funcs [--filter=<pattern>|-F <pattern>]

Thank you,

--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com