Re: [PATCH -perf/perf/core 5/6] perf probe: Add variable filter support

Franck Bui-Huu
2011-01-13T21:18:34Z

Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> writes:

> Add filters support for available variable list.
> Default filter is "!__k???tab_*&!__crc_*" for
> filtering out automatically generated symbols.
>
> The format of filter rule is "[!]GLOBPATTERN", so
> you can use wild cards. If the filter rule starts with
> '!', matched variables are filter out.
>
> e.g.)
> # perf probe -V schedule --externs --filter=cpu*

I'm wondering if the different syntax below could be simpler:

$ perf probe add <probe>
$ perf probe del <probe>
$ perf probe show

$ perf probe list <line>
... --vars[=<pattern>] [--externs] <probe>
... --funcs[=<pattern>]

instead of respectively:

$ perf probe --add=<probe>
$ perf probe --del=<probe>
$ perf probe [--list|-l]

$ perf probe [--line|-L] <line>
$ perf probe -V <probe> [--externs] [--filter=<pattern>]
$ perf probe --funcs

--
Franck