Re: [patch 32/37] parisc: Use generic irq Kconfig

James Bottomley
2011-01-20T04:59:04Z

On Wed, 2011-01-19 at 23:16 +0100, Thomas Gleixner wrote:
> On Wed, 19 Jan 2011, James Bottomley wrote:
>
> > On Wed, 2011-01-19 at 21:49 +0000, Thomas Gleixner wrote:
> > > plain text document attachment (parisc-use-generic-irq-Kconfig.patch)
> > > No functional change.
> >
> > Not quite true ... you take out GENERIC_HARDIRQS but select
> > HAVE_GENERIC_HARDIRQS ... is that right?
>
> HAVE_GENERIC_HARDIRQS enables the Kconfig file in kernel/irq/

Ah, OK, thanks.

> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Kyle McMartin <kyle@mcmartin.ca>
> >
> > Plus, it doesn't apply:
> >
> > Hunk #1 FAILED at 12.
> > Hunk #2 FAILED at 65.
> > 2 out of 2 hunks FAILED -- saving rejects to file
> > arch/parisc/Kconfig.rej
> >
> > It looks like it was made before we did our generic irq conversion in
> > the 2.6.36 merge window.
>
> You meant 38 window :)

No ... it went in when Kyle was maintainer ... so that's at least 37 or
before.

> Patch is against 38-rc1 but depends on [patch
> 24/37] genirq: Remove __do_IRQ in this very same series.

Ah, great ... missed that one. With this it all seems to work, so you
can add my ack to the parisc piece.

James