Re: [patch 36/37] tile: Use generic irq Kconfig

Chris Metcalf
2011-01-20T19:11:36Z

On 1/20/2011 2:08 PM, Sam Ravnborg wrote:
> On Thu, Jan 20, 2011 at 01:54:27PM -0500, Chris Metcalf wrote:
>> On 1/19/2011 4:50 PM, Thomas Gleixner wrote:
>>> No functional change.
>>>
>>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Chris Metcalf <cmetcalf@tilera.com>
>>> ---
>>> arch/tile/Kconfig | 16 ++++++----------
>>> 1 file changed, 6 insertions(+), 10 deletions(-)
>>>
>>> Index: linux-2.6/arch/tile/Kconfig
>>> ===================================================================
>>> --- linux-2.6.orig/arch/tile/Kconfig
>>> +++ linux-2.6/arch/tile/Kconfig
>>> @@ -1,22 +1,18 @@
>>> # For a description of the syntax of this configuration file,
>>> # see Documentation/kbuild/config-language.txt.
>>>
>>> +config TILE
>>> + def_bool y
>>> + select HAVE_GENERIC_HARDIRQS
>>> + select GENERIC_IRQ_PROBE
>>> + select GENERIC_PENDING_IRQ if SMP
>>> +
>>> [...]
>> I'm not sure it's legal to have two "config TILE" blocks in this Kconfig
>> file; there's already one further down.
> It is OK to have two "config TILE" blocks.
> You should take care of moving the other one up after this goes in.

In that case I'm happy to ack the original patch.

Acked-by: Chris Metcalf <cmetcalf@tilera.com>

--
Chris Metcalf, Tilera Corp.