From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Huang Ying <ying.huang@intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] Fix the wrong corrupted page information of hugetlb page.
Date: Fri, 21 Jan 2011 15:05:27 +0900 [thread overview]
Message-ID: <4D392227.6030603@np.css.fujitsu.com> (raw)
In-Reply-To: <20110121051251.GA16406@spritzera.linux.bs1.fc.nec.co.jp>
Hi, Naoya-san
(2011/01/21 14:12), Naoya Horiguchi wrote:
> Hi,
>
>> @@ -991,18 +995,32 @@ int __memory_failure(unsigned long pfn, int trapno, int flags)
>> action_result(pfn, "free buddy", DELAYED);
>> return 0;
>> } else if (PageHuge(hpage)) {
>> - /*
>> - * Check "just unpoisoned", "filter hit", and
>> - * "race with other subpage."
>> - */
>> lock_page_nosync(hpage);
>> - if (!PageHWPoison(p)
>> - || (hwpoison_filter(p) && TestClearPageHWPoison(p))
>> - || (p != hpage && TestSetPageHWPoison(hpage))) {
>> - atomic_long_sub(nr_pages, &mce_bad_pages);
>> + /* Check "just unpoisoned". */
>> + if (!PageHWPoison(hpage)) {
> ^^^^^
> Isn't this "p" (as you changed in patch 2/3) ?
Yes, you are right.
I will send a new one as soon as possible.
Thanks.
Best Regards,
Jin Dongming
>
> -- Naoya Horiguchi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2011-01-21 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 1:24 [PATCH 3/3] Fix the wrong corrupted page information of hugetlb page Jin Dongming
2011-01-21 5:12 ` Naoya Horiguchi
2011-01-21 6:05 ` Jin Dongming [this message]
2011-01-21 8:17 ` [PATCH 3/3 -v2] " Jin Dongming
2011-01-21 9:56 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D392227.6030603@np.css.fujitsu.com \
--to=jin.dongming@np.css.fujitsu.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox