From: Jiri Slaby <jirislaby@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlie <airlied@linux.ie>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/ringbuffer: Fix use of stale HEAD position whilst polling for space
Date: Fri, 21 Jan 2011 09:35:41 +0100 [thread overview]
Message-ID: <4D39455D.4070808@gmail.com> (raw)
In-Reply-To: <1295545279-21335-1-git-send-email-chris@chris-wilson.co.uk>
On 01/20/2011 06:41 PM, Chris Wilson wrote:
> During suspend, Linus found that his machine would hang for 3 seconds,
> and identified that intel_ring_buffer_wait() was the culprit:
FWIW works for me. From 4s I'm back to:
PM: suspend of devices complete after 1087.670 msecs
BTW I did this change as there are loops running out of bounds of this
array added in 1ec14ad3.
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -52,7 +52,7 @@ struct intel_ring_buffer {
u32 irq_seqno; /* last seq seem at irq
time */
u32 waiting_seqno;
- u32 sync_seqno[I915_NUM_RINGS-1];
+ u32 sync_seqno[I915_NUM_RINGS];
atomic_t irq_refcount;
bool __must_check (*irq_get)(struct intel_ring_buffer *ring);
void (*irq_put)(struct intel_ring_buffer *ring);
thanks,
--
js
next prev parent reply other threads:[~2011-01-21 8:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 2:39 more intel drm issues (was Re: [git pull] drm intel only fixes) Linus Torvalds
2011-01-20 4:55 ` Jeff Chua
2011-01-20 6:22 ` Linus Torvalds
2011-01-20 10:17 ` Jeff Chua
2011-01-20 10:25 ` Chris Wilson
2011-01-20 16:07 ` Linus Torvalds
2011-01-20 17:38 ` Chris Wilson
2011-01-20 17:51 ` Linus Torvalds
2011-01-20 20:44 ` Linus Torvalds
2011-01-20 17:41 ` [PATCH] drm/i915/ringbuffer: Fix use of stale HEAD position whilst polling for space Chris Wilson
2011-01-21 8:35 ` Jiri Slaby [this message]
2011-01-21 10:11 ` [PATCH] drm/i915: Fix use of invalid array size for ring->sync_seqno Chris Wilson
2011-01-22 22:24 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D39455D.4070808@gmail.com \
--to=jirislaby@gmail.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox