From: "H. Peter Anvin" <hpa@zytor.com>
To: Tejun Heo <tj@kernel.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [cpuops cmpxchg double V2 1/4] Generic support for this_cpu_cmpxchg_double
Date: Fri, 21 Jan 2011 07:31:55 -0800 [thread overview]
Message-ID: <4D39A6EB.70705@zytor.com> (raw)
In-Reply-To: <20110121092649.GA2832@htj.dyndns.org>
On 01/21/2011 01:26 AM, Tejun Heo wrote:
> Hello,
>
> On Fri, Jan 21, 2011 at 09:31:02AM +0200, Pekka Enberg wrote:
>> On 1/8/11 7:24 PM, Tejun Heo wrote:
>>> Call me weird but I like this one than others. It sure is ugly but
>>> the operation itself isn't a particularly pretty so it kinda matches.
>>> Also, this one is the least error prone and more consistent with other
>>> cpu ops.
>>
>> So what are we going to do about this patch? I'd love to merge
>> Christoph's SLUB patches for linux-next now that .38-rc1 is out.
>
> At least you like it, which is good.
>
> I don't think the currently proposed one with two separate parameters
> is significantly better than other alternatives and vice-versa. They
> all have slightly different ugliness and error proneness issues.
>
> That said, I still like the double parameter one best, and, unless
> there are distinctively good reasons to choose another one, I'm gonna
> commit it to percpu tree in a few days so that merge can proceed. So,
> if you have something to say, now would be a good time to assert it.
>
I really object to passing two pointers where one of them has to be a
fixed offset to the other. That really doesn't make any sense.
-hpa
next prev parent reply other threads:[~2011-01-21 15:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 20:45 [cpuops cmpxchg double V2 0/4] this_cpu_cmpxchg_double support Christoph Lameter
2011-01-06 20:45 ` [cpuops cmpxchg double V2 1/4] Generic support for this_cpu_cmpxchg_double Christoph Lameter
2011-01-06 21:08 ` Mathieu Desnoyers
2011-01-06 21:43 ` Christoph Lameter
2011-01-06 22:05 ` H. Peter Anvin
2011-01-07 15:15 ` Christoph Lameter
2011-01-07 18:04 ` Mathieu Desnoyers
2011-01-07 18:41 ` Christoph Lameter
2011-01-08 17:24 ` Tejun Heo
2011-01-09 8:33 ` Pekka Enberg
2011-01-21 7:31 ` Pekka Enberg
2011-01-21 9:26 ` Tejun Heo
2011-01-21 15:31 ` H. Peter Anvin [this message]
2011-01-21 15:48 ` Tejun Heo
2011-01-21 16:30 ` H. Peter Anvin
2011-01-21 16:34 ` Tejun Heo
2011-01-21 16:54 ` Mathieu Desnoyers
2011-01-21 17:07 ` Christoph Lameter
2011-01-21 17:50 ` Mathieu Desnoyers
2011-01-21 18:06 ` Christoph Lameter
2011-01-21 18:37 ` Mathieu Desnoyers
2011-01-21 17:08 ` Tejun Heo
2011-01-21 17:13 ` H. Peter Anvin
2011-01-21 17:19 ` Tejun Heo
2011-01-24 6:01 ` H. Peter Anvin
2011-02-25 13:09 ` Pekka Enberg
2011-02-25 13:19 ` Tejun Heo
2011-02-25 16:26 ` Christoph Lameter
2011-02-25 16:37 ` Tejun Heo
2011-02-25 16:43 ` Christoph Lameter
2011-02-25 16:38 ` Eric Dumazet
2011-02-25 16:45 ` Christoph Lameter
2011-01-21 17:24 ` Christoph Lameter
2011-01-21 17:42 ` Mathieu Desnoyers
2011-01-21 17:50 ` Christoph Lameter
2011-01-21 18:10 ` Mathieu Desnoyers
2011-01-21 18:42 ` Christoph Lameter
2011-01-21 18:31 ` H. Peter Anvin
2011-01-21 18:46 ` Christoph Lameter
2011-01-21 19:32 ` Mathieu Desnoyers
2011-01-23 18:00 ` H. Peter Anvin
2011-01-06 20:45 ` [cpuops cmpxchg double V2 2/4] x86: this_cpu_cmpxchg_double() support Christoph Lameter
2011-01-06 20:45 ` [cpuops cmpxchg double V2 3/4] slub: Get rid of slab_free_hook_irq() Christoph Lameter
2011-01-06 20:45 ` [cpuops cmpxchg double V2 4/4] Lockless (and preemptless) fastpaths for slub Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D39A6EB.70705@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=penberg@cs.helsinki.fi \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox