Re: [PATCH] i2c: octeon: Make the timeout 1*HZ instead of 1 jiffy

[Bernhard Walle <walle@corscience.de>]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

Hi Jean,

Am 24.01.2011 13:14, schrieb Jean Delvare:
>>  	.owner = THIS_MODULE,
>>  	.name = "OCTEON adapter",
>>  	.algo = &octeon_i2c_algo,
>> -	.timeout = 2,
>> +	.timeout = HZ,
>>  };
> 
> This is a large timeout value, much larger than any value the
> i2c-octeon driver was using today for any possible value of HZ.
> Wouldn't it make more sense to set it to HZ / 50, which is 2 for HZ =
> 100, leaving the setting unchanged for this common case at least?

To be honest, I had problems with timeout=2 that go away with
timeout=HZ. But I cannot be sure that this is a problem with my hardware
that is not present with other devices.

The drivers that use HZ are i2c-mpc.c and i2c-pca-platform.c, but I
don't know the hardware that much so that I really can compare the values.

So yes, you're right. A patch modifying the timeout value should be an
extra patch, so I will resend the current patch to use HZ/50.


Regards,
Bernhard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]