Re: [PATCH 2/4] arch/arm/mach-at91/clock.c: Add missing IS_ERR test

Vasiliy Kulikov
2011-01-24T20:14:57Z

On Mon, Jan 24, 2011 at 21:09 +0100, Julia Lawall wrote:
> On Mon, 24 Jan 2011, Vasiliy Kulikov wrote:
> > clk_get() is defined per-architecture, sometimes it is NULL only.
>
> In this case there is a definition in the same file, so it doesn't seem
> necessary to worry about possible other ones. Unless there is some goal
> in the future to remove the local one?

My oppinion is that even such architecture dependent code written in
architecure indepenent way is highly desirable. Besides more clean code
it is probably review by smaller group of people, so it is potentially
more buggy.

Thanks,

--
Vasiliy