Re: [PATCH 2/4] arch/arm/mach-at91/clock.c: Add missing IS_ERR test

Russell King - ARM Linux
2011-01-25T11:17:52Z

On Tue, Jan 25, 2011 at 12:12:45PM +0100, walter harms wrote:
> Am 25.01.2011 11:43, schrieb Russell King - ARM Linux:
> > On Tue, Jan 25, 2011 at 11:33:16AM +0100, walter harms wrote:
> >> Would it be more easy to return NULL in the error case of clk_get() instead
> >> of ERR_PTR(-ENOENT) ?
> >>
> >> So the default could be return NULL and an architecture depending solution
> >> replacing that.
> >
> > That's not how the API is defined. The API defines error-pointers to be
> > errors, everything should be considered valid. Please don't go down the
> > route of doing something architecturally different from that.
> >
> > What if, say, you couldn't return the struct clk because maybe it could
> > only be controlled by one user? Returning an EBUSY error pointer would
> > indicate this condition. What if the module providing the struct clk
> > hasn't finished initializing - that's another reason for EBUSY rather
> > than ENOENT.
> >
> > Error codes are useful to describe why something failed. NULL pointers
> > can't do that.
> >
>
> On Mon, 24 Jan 2011, Vasiliy Kulikov wrote:
> >
> ...
> > clk_get() is defined per-architecture, sometimes it is NULL only.
> >
>
> So these is a bug ? They should return -ENOENT ?

You're stuck in "NULL is an error" mode. struct clk * is a cookie which
only the clk API implementation understands. It must not be treated as
anything different by drivers. The only defined values for drivers are
error pointer codes which translate to errors. Everything else, drivers
must assume is valid. Drivers are not allowed to dereference struct clk.

It is for the clk API to interpret the struct clk * cookie as it sees fit.