From: Cyrill Gorcunov <gorcunov@gmail.com>
To: eranian@google.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com, robert.richter@amd.com, acme@redhat.com,
ming.m.lin@intel.com
Subject: Re: [PATCH] perf_events: fix Pentium4 raw event validation
Date: Tue, 25 Jan 2011 19:48:53 +0300 [thread overview]
Message-ID: <4D3EFEF5.80406@gmail.com> (raw)
In-Reply-To: <4d3efb2f.1252d80a.1a80.ffffc83f@mx.google.com>
On 01/25/2011 06:32 PM, Stephane Eranian wrote:
> This patches fixes some issies with raw event validation on Pentium 4 (Netburst)
> processors.
>
> As I was testing libpfm4 Netburst support, I ran into two problems in the
> p4_validate_raw_event() function:
> - the shared field must be checked ONLY when HT is on
> - the binding to ESCR register was missing
>
> The second item was causing raw events to not be encoded correctly compared
> to generic PMU events.
>
> With this patch, I can now pass Netburst events to libpfm4 examples and
> get meaningful results:
> $ task -e global_power_events:running:u noploop 1
> noploop for 1 seconds
> 3,206,304,898 global_power_events:running
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Thanks a lot Stephane!
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
--
Cyrill
next prev parent reply other threads:[~2011-01-25 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 15:32 [PATCH] perf_events: fix Pentium4 raw event validation Stephane Eranian
2011-01-25 16:48 ` Cyrill Gorcunov [this message]
2011-01-26 7:26 ` [tip:perf/urgent] perf: Fix " tip-bot for Stephane Eranian
2011-01-27 18:28 ` tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3EFEF5.80406@gmail.com \
--to=gorcunov@gmail.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox