Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management

Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management

[Jeff Chua]

On Tue, Jan 25, 2011 at 5:37 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Monday, January 24, 2011, Henrique de Moraes Holschuh wrote:
> It turns out there's a bug in intel_idle causing people a lot of pain 
> with CPU hotplugging.  Should be fixed now it the Linus' tree.

Uh, I see the git fix now. Thanks. The workaround I did was to manually 
offline all CPUs before suspend and that fixed it too.

As for the thinkpad-acpi, here a little patch to disable all hotkeys so 
that Fn-F4 works natively to suspend-to-memory when 
CONFIG_THINKPAD_ACPI_HOTKEY_POLL is not set.

Thanks,
Jeff

--- lx/drivers/platform/x86/thinkpad_acpi.c.org	2011-01-22 21:48:05.000000000 +0800
+++ lx/drivers/platform/x86/thinkpad_acpi.c	2011-01-22 21:55:14.000000000 +0800
@@ -8776,10 +8776,12 @@
  	{
  		.data = &thinkpad_acpi_driver_data,
  	},
+#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
  	{
  		.init = hotkey_init,
  		.data = &hotkey_driver_data,
  	},
+#endif
  	{
  		.init = bluetooth_init,

thinkpad-acpi: fn-f4 issues

[Henrique de Moraes Holschuh]

(cc: trimmed down, as this is now a thinkpad-acpi matter)

On Tue, 25 Jan 2011, Jeff Chua wrote:
> As for the thinkpad-acpi, here a little patch to disable all hotkeys
> so that Fn-F4 works natively to suspend-to-memory when
> CONFIG_THINKPAD_ACPI_HOTKEY_POLL is not set.
> 
> Thanks,
> Jeff
> 
> --- lx/drivers/platform/x86/thinkpad_acpi.c.org	2011-01-22 21:48:05.000000000 +0800
> +++ lx/drivers/platform/x86/thinkpad_acpi.c	2011-01-22 21:55:14.000000000 +0800
> @@ -8776,10 +8776,12 @@
>  	{
>  		.data = &thinkpad_acpi_driver_data,
>  	},
> +#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
>  	{
>  		.init = hotkey_init,
>  		.data = &hotkey_driver_data,
>  	},
> +#endif

That will basicaly lobotomize the driver, as the "hotkeys" are really the
entire firmware event interface(!).

Which thinkpad do you have that need CONFIG_THINKPAD_ACPI_HOTKEY_POLL to
handle Fn+F4?   I don't expect that to be needed on anything newer than a
T32...

Can I have the full kernel log, please?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Dominik Kopp]

[-- Attachment #1: Type: text/plain, Size: 2514 bytes --]

Hi,

I have also a X100e and the Fn-F4 (suspend-to-memory) and Fn-F12 
(suspend-to-disk) are not working. (no effect at all)

some dmesg lines:
[   15.358464] thinkpad_acpi: ThinkPad ACPI Extras v0.24
[   15.358468] thinkpad_acpi: http://ibm-acpi.sf.net/
[   15.358471] thinkpad_acpi: ThinkPad BIOS 6XET44WW (1.27 ), EC 
6XHT42WW-1.182000
[   15.358474] thinkpad_acpi: Lenovo ThinkPad X100e, model 287627G
[   15.360861] thinkpad_acpi: detected a 8-level brightness capable ThinkPad
[   15.360924] thinkpad_acpi: possible tablet mode switch found; 
ThinkPad in laptop mode
[   15.362664] thinkpad_acpi: asked for hotkey mask 0x040988fc, but 
firmware forced it to 0x000988fc
[   15.367253] thinkpad_acpi: setting the hotkey mask to 0x00ffffff is 
likely not the best way to go about it
[   15.367257] thinkpad_acpi: please consider using the driver defaults, 
and refer to up-to-date thinkpad-acpi documentation
[   15.378453] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio 
is unblocked
[   15.389678] thinkpad_acpi: rfkill switch tpacpi_wwan_sw: radio is 
unblocked
[   15.390251] Registered led device: tpacpi::thinklight
[   15.390658] Registered led device: tpacpi::power
[   15.391086] Registered led device: tpacpi::standby
[   15.391470] Registered led device: tpacpi::thinkvantage

complete dmesg attached. (is this the "full kernel log"?)

PS: I'm using openSUSE 11.3 with 2.6.37 kernel (from suse's HEAD repository)

Am 25.01.2011 16:13, schrieb Henrique de Moraes Holschuh:
> (cc: trimmed down, as this is now a thinkpad-acpi matter)
>
> On Tue, 25 Jan 2011, Jeff Chua wrote:
>> As for the thinkpad-acpi, here a little patch to disable all hotkeys
>> so that Fn-F4 works natively to suspend-to-memory when
>> CONFIG_THINKPAD_ACPI_HOTKEY_POLL is not set.
>>
>> Thanks,
>> Jeff
>>
>> --- lx/drivers/platform/x86/thinkpad_acpi.c.org	2011-01-22 21:48:05.000000000 +0800
>> +++ lx/drivers/platform/x86/thinkpad_acpi.c	2011-01-22 21:55:14.000000000 +0800
>> @@ -8776,10 +8776,12 @@
>>   	{
>>   		.data =&thinkpad_acpi_driver_data,
>>   	},
>> +#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
>>   	{
>>   		.init = hotkey_init,
>>   		.data =&hotkey_driver_data,
>>   	},
>> +#endif
> That will basicaly lobotomize the driver, as the "hotkeys" are really the
> entire firmware event interface(!).
>
> Which thinkpad do you have that need CONFIG_THINKPAD_ACPI_HOTKEY_POLL to
> handle Fn+F4?   I don't expect that to be needed on anything newer than a
> T32...
>
> Can I have the full kernel log, please?
>


[-- Attachment #2: X100e_dmesg.tar.gz --]
[-- Type: application/x-gzip, Size: 17744 bytes --]

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Henrique de Moraes Holschuh]

On Tue, 25 Jan 2011, Dominik Kopp wrote:
> I have also a X100e and the Fn-F4 (suspend-to-memory) and Fn-F12
> (suspend-to-disk) are not working. (no effect at all)

> [   15.362664] thinkpad_acpi: asked for hotkey mask 0x040988fc, but
> firmware forced it to 0x000988fc

The driver IS asking for Fn+F4 events.  Please send me the output of
acpidump, gzipped.

In the meanwhile, check if the input device is producing events when
you're pressing Fn+f4.  It could well be sending KEY_SUSPEND, but if
there's nobody listening...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Dominik Kopp]

[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]

Am 26.01.2011 00:16, schrieb Henrique de Moraes Holschuh:
> The driver IS asking for Fn+F4 events. Please send me the output of
> acpidump, gzipped.
acpidump attached.
> In the meanwhile, check if the input device is producing events when
> you're pressing Fn+f4.  It could well be sending KEY_SUSPEND, but if
> there's nobody listening...
>
do you mean xev?
if yes: they are producing KeyPress and KeyRelease events (but nothing else)

see logs full (attached)

-----------
KeyPress event, serial 34, synthetic NO, window 0x4800001,
     root 0xa5, subw 0x0, time 8303278, (-91,518), root:(1094,541),
     state 0x0, keycode 150 (keysym 0x1008ff2f, XF86Sleep), same_screen YES,
     XLookupString gives 0 bytes:
     XmbLookupString gives 0 bytes:
     XFilterEvent returns: False

KeyRelease event, serial 34, synthetic NO, window 0x4800001,
     root 0xa5, subw 0x0, time 8303278, (-91,518), root:(1094,541),
     state 0x0, keycode 150 (keysym 0x1008ff2f, XF86Sleep), same_screen YES,
     XLookupString gives 0 bytes:
     XFilterEvent returns: False

KeyPress event, serial 35, synthetic NO, window 0x4800001,
     root 0xa5, subw 0x0, time 8305536, (-91,518), root:(1094,541),
     state 0x0, keycode 213 (keysym 0x1008ffa7, XF86Suspend), 
same_screen YES,
     XLookupString gives 0 bytes:
     XmbLookupString gives 0 bytes:
     XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x4800001,
     root 0xa5, subw 0x0, time 8305536, (-91,518), root:(1094,541),
     state 0x0, keycode 213 (keysym 0x1008ffa7, XF86Suspend), 
same_screen YES,
     XLookupString gives 0 bytes:
     XFilterEvent returns: False
---------


[-- Attachment #2: acpidump_x100e.tar.gz --]
[-- Type: application/x-gzip, Size: 55069 bytes --]

[-- Attachment #3: xev --]
[-- Type: text/plain, Size: 6378 bytes --]

hitting Fn+F4  (no action)
hitting Fn+F12 (no action)
hitting Fn+F1  (Audio lower works)
------------
linux-ypl4:/home/dom # xev
Outer window is 0x4800001, inner window is 0x4800002

PropertyNotify event, serial 8, synthetic NO, window 0x4800001,
    atom 0x27 (WM_NAME), time 8298125, state PropertyNewValue

PropertyNotify event, serial 9, synthetic NO, window 0x4800001,
    atom 0x22 (WM_COMMAND), time 8298125, state PropertyNewValue

PropertyNotify event, serial 10, synthetic NO, window 0x4800001,
    atom 0x28 (WM_NORMAL_HINTS), time 8298125, state PropertyNewValue

CreateNotify event, serial 11, synthetic NO, window 0x4800001,
    parent 0x4800001, window 0x4800002, (10,10), width 50, height 50
border_width 4, override NO

PropertyNotify event, serial 12, synthetic NO, window 0x4800001,
    atom 0x1c4 (_KDE_NET_WM_USER_CREATION_TIME), time 8298126, state PropertyNewValue

PropertyNotify event, serial 14, synthetic NO, window 0x4800001,
    atom 0x14f (WM_PROTOCOLS), time 8298127, state PropertyNewValue

MapNotify event, serial 15, synthetic NO, window 0x4800001,
    event 0x4800001, window 0x4800002, override NO

ConfigureNotify event, serial 18, synthetic NO, window 0x4800001,
    event 0x4800001, window 0x4800001, (0,0), width 178, height 178,
    border_width 0, above 0x2270580, override NO

ReparentNotify event, serial 18, synthetic NO, window 0x4800001,
    event 0x4800001, window 0x4800001, parent 0x1e0c561,
    (0,0), override NO

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x178 (_NET_WM_STATE), time 8298135, state PropertyNewValue

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x1d8 (_NET_WM_DESKTOP), time 8298140, state PropertyNewValue

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x1c9 (_NET_FRAME_EXTENTS), time 8298153, state PropertyNewValue

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x194 (_KDE_NET_WM_FRAME_STRUT), time 8298153, state PropertyNewValue

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x1de (_NET_WM_ALLOWED_ACTIONS), time 8298153, state PropertyNewValue

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x178 (_NET_WM_STATE), time 8298154, state PropertyNewValue

MapNotify event, serial 18, synthetic NO, window 0x4800001,
    event 0x4800001, window 0x4800001, override NO

VisibilityNotify event, serial 18, synthetic NO, window 0x4800001,
    state VisibilityFullyObscured

PropertyNotify event, serial 18, synthetic NO, window 0x4800001,
    atom 0x156 (WM_STATE), time 8298155, state PropertyNewValue

FocusIn event, serial 18, synthetic NO, window 0x4800001,
    mode NotifyNormal, detail NotifyNonlinear

KeymapNotify event, serial 18, synthetic NO, window 0x0,
    keys:  0   0   0   0   16  0   0   0   0   0   0   0   0   0   0   0   
           0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   

ConfigureNotify event, serial 18, synthetic YES, window 0x4800001,
    event 0x4800001, window 0x4800001, (1185,23), width 178, height 178,
    border_width 0, above 0x0, override NO

VisibilityNotify event, serial 18, synthetic NO, window 0x4800001,
    state VisibilityUnobscured

Expose event, serial 18, synthetic NO, window 0x4800001,
    (0,0), width 178, height 10, count 3

Expose event, serial 18, synthetic NO, window 0x4800001,
    (0,10), width 10, height 58, count 2

Expose event, serial 18, synthetic NO, window 0x4800001,
    (68,10), width 110, height 58, count 1

Expose event, serial 18, synthetic NO, window 0x4800001,
    (0,68), width 178, height 110, count 0

KeyRelease event, serial 20, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8298201, (-91,518), root:(1094,541),
    state 0x0, keycode 36 (keysym 0xff0d, Return), same_screen YES,
"   XLookupString gives 1 bytes: (0d) "
    XFilterEvent returns: False

PropertyNotify event, serial 33, synthetic NO, window 0x4800001,
    atom 0x1db (_NET_WM_ICON_GEOMETRY), time 8298886, state PropertyNewValue

MappingNotify event, serial 34, synthetic NO, window 0x0,
    request MappingKeyboard, first_keycode 8, count 248

KeyPress event, serial 34, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8303278, (-91,518), root:(1094,541),
    state 0x0, keycode 150 (keysym 0x1008ff2f, XF86Sleep), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 34, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8303278, (-91,518), root:(1094,541),
    state 0x0, keycode 150 (keysym 0x1008ff2f, XF86Sleep), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyPress event, serial 35, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8305536, (-91,518), root:(1094,541),
    state 0x0, keycode 213 (keysym 0x1008ffa7, XF86Suspend), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8305536, (-91,518), root:(1094,541),
    state 0x0, keycode 213 (keysym 0x1008ffa7, XF86Suspend), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

MappingNotify event, serial 35, synthetic NO, window 0x0,
    request MappingKeyboard, first_keycode 8, count 248

FocusOut event, serial 35, synthetic NO, window 0x4800001,
    mode NotifyGrab, detail NotifyAncestor

FocusIn event, serial 36, synthetic NO, window 0x4800001,
    mode NotifyUngrab, detail NotifyAncestor

KeymapNotify event, serial 36, synthetic NO, window 0x0,
    keys:  1   0   0   0   0   0   0   0   0   0   0   0   0   0   0   4   
           0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   

KeyRelease event, serial 36, synthetic NO, window 0x4800001,
    root 0xa5, subw 0x0, time 8309738, (-91,518), root:(1094,541),
    state 0x0, keycode 122 (keysym 0x1008ff11, XF86AudioLowerVolume), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

FocusOut event, serial 36, synthetic NO, window 0x4800001,
    mode NotifyNormal, detail NotifyNonlinear

VisibilityNotify event, serial 36, synthetic NO, window 0x4800001,
    state VisibilityPartiallyObscured
^C
linux-ypl4:/home/dom #

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Henrique de Moraes Holschuh]

On Wed, 26 Jan 2011, Dominik Kopp wrote:
> Am 26.01.2011 00:16, schrieb Henrique de Moraes Holschuh:
> >The driver IS asking for Fn+F4 events. Please send me the output of
> >acpidump, gzipped.
> acpidump attached.
> >In the meanwhile, check if the input device is producing events when
> >you're pressing Fn+f4.  It could well be sending KEY_SUSPEND, but if
> >there's nobody listening...
> >
> do you mean xev?
> if yes: they are producing KeyPress and KeyRelease events (but nothing else)

So, not a driver bug.  Take it up with your userspace distro...

>     state 0x0, keycode 150 (keysym 0x1008ff2f, XF86Sleep), same_screen YES,

It is even mapped to the correct X keysim...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: thinkpad-acpi: fn-f4 issues

[Jeff Chua]

On Tue, Jan 25, 2011 at 11:13 PM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> That will basicaly lobotomize the driver, as the "hotkeys" are really the
> entire firmware event interface(!).

Didn't know that.

> Which thinkpad do you have that need CONFIG_THINKPAD_ACPI_HOTKEY_POLL to
> handle Fn+F4?   I don't expect that to be needed on anything newer than a
> T32...

X201s which is quite new.


> Can I have the full kernel log, please?

thinkpad_acpi: ThinkPad ACPI Extras v0.24
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6QET62WW (1.32 ), EC 6QHT31WW-1.12
thinkpad_acpi: Lenovo ThinkPad X201s, model 5413FGA
thinkpad_acpi: detected a 8-level brightness capable ThinkPad
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: possible tablet mode switch found; ThinkPad in laptop mode
thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is blocked
Registered led device: tpacpi::thinklight
Registered led device: tpacpi::power
Registered led device: tpacpi::standby
Registered led device: tpacpi::thinkvantage
thinkpad_acpi: volume: disabled as there is no ALSA support in this kernel
input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input5

And the volume up/down does not work either even with thinkpad ALSA
support enabled.

Thanks,
Jeff.

Re: thinkpad-acpi: fn-f4 issues

[Henrique de Moraes Holschuh]

On Wed, 26 Jan 2011, Jeff Chua wrote:
> > Which thinkpad do you have that need CONFIG_THINKPAD_ACPI_HOTKEY_POLL to
> > handle Fn+F4?   I don't expect that to be needed on anything newer than a
> > T32...
> 
> X201s which is quite new.

Yay.  Send me dmidecode (XXX-out UUID and serial numbers) and output of of
acpidump, please.  And check that you have the latest version of the
firmware installed.

> thinkpad_acpi: ThinkPad ACPI Extras v0.24
> thinkpad_acpi: http://ibm-acpi.sf.net/
> thinkpad_acpi: ThinkPad BIOS 6QET62WW (1.32 ), EC 6QHT31WW-1.12
> thinkpad_acpi: Lenovo ThinkPad X201s, model 5413FGA
> thinkpad_acpi: detected a 8-level brightness capable ThinkPad
> thinkpad_acpi: radio switch found; radios are enabled
> thinkpad_acpi: possible tablet mode switch found; ThinkPad in laptop mode
> thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is blocked

Well, it didn't complain about hotkeys, so it probably got all those that it
requested, which includes Fn+F4.  When in doubt, please either run the
driver in debug mode, or check the hotkey_mask in sysfs.

Please check with xev and something like input-events or some other
input-device snooper whether you get events when you press Fn+F4.  Maybe
userspace is ignoring it.

It should be something else, since poll mode seems to fix it, but let's get
the easy stuff out of the way first.

> thinkpad_acpi: volume: disabled as there is no ALSA support in this kernel
> input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input5
> 
> And the volume up/down does not work either even with thinkpad ALSA
> support enabled.

Check if something in userspace is listening to these keys.  They go over
the regular keyboard interface.  You don't have volume hotkeys or a mixer,
you just have two regular keys.  You'll be lucky if you still have a real
MUTE gate outside of the control of the HDA mixer...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Henrique de Moraes Holschuh]

On Wed, 26 Jan 2011, Jeff Chua wrote:
> > requested, which includes Fn+F4.  When in doubt, please either run the
> > driver in debug mode, or check the hotkey_mask in sysfs.
> >
> > Please check with xev and something like input-events or some other
> > input-device snooper whether you get events when you press Fn+F4.  Maybe
> > userspace is ignoring it.
> 
> xev reported both up/down. I'm using mplayer and it doesn't see those
> events.

Now I am confused.  Did you get any xev events for Fn+F4?  Or do you mean
volume up/down?

> Mute is working fine.  And on a separate topic, I simply couldn't get the
> "mic" to work. Alsamixer reported these ...

I wouldn't know what to do about that, but I bet someone on the thinkpad-ml
does, so maybe you should ask there.  You did check that the mic-mute button
is not active, I assume?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] thinkpad-acpi: fn-f4 issues

[Jeff Chua]

On Sun, Jan 30, 2011 at 1:55 AM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
>
> On Wed, 26 Jan 2011, Jeff Chua wrote:
>
> > xev reported both up/down. I'm using mplayer and it doesn't see those
> > events.
>
> Now I am confused.  Did you get any xev events for Fn+F4?  Or do you mean
> volume up/down?

No event for Fn+F4 with CONFIG_THINKPAD_ACPI_HOTKEY_POLL=y, and
Suspend doesn't work.

With CONFIG_THINKPAD_ACPI_HOTKEY_POLL unset, Syspend works with Fn+F4.

xev reported events when volume up/down are pressed.

>
> > Mute is working fine.  And on a separate topic, I simply couldn't get the
> > "mic" to work. Alsamixer reported these ...
>
> I wouldn't know what to do about that, but I bet someone on the thinkpad-ml
> does, so maybe you should ask there.  You did check that the mic-mute button
> is not active, I assume?

There's no option to unmute the mic. I've tried alsamixer, but
couldn't find it there.

Thanks,
Jeff