From: Jeff Garzik <jeff@garzik.org>
To: Aaron Durbin <adurbin@google.com>
Cc: Mike Waychison <mikew@google.com>, Greg KH <greg@kroah.com>,
torvalds@linux-foundation.org, San Mehat <san@google.com>,
Duncan Laurie <dlaurie@google.com>,
linux-kernel@vger.kernel.org, Tim Hockin <thockin@google.com>
Subject: Re: [PATCH v1 1/6] Add oops notification chain.
Date: Tue, 25 Jan 2011 16:54:33 -0500 [thread overview]
Message-ID: <4D3F4699.60809@garzik.org> (raw)
In-Reply-To: <AANLkTim4fG0-F0+E-DHa4=XGdk1rFbRA68nvt9bfURiK@mail.gmail.com>
On 01/25/2011 04:43 PM, Aaron Durbin wrote:
> On Tue, Jan 25, 2011 at 1:36 PM, Jeff Garzik<jeff@garzik.org> wrote:
>> On 01/25/2011 03:01 PM, Mike Waychison wrote:
>>>
>>> On Mon, Jan 24, 2011 at 6:06 PM, Greg KH<greg@kroah.com> wrote:
>>>>
>>>> On Mon, Jan 24, 2011 at 04:24:39PM -0800, Mike Waychison wrote:
>>>>>
>>>>> From: Aaron Durbin<adurbin@google.com>
>>>>>
>>>>> Later firmware patches in this series would like to be able to be
>>>>> notified whenever an oops occurs on the system, so that it can be
>>>>> recorded in the boot log.
>>>>>
>>>>> This patch introduces a notifier_block called "oops_notifier_list"
>>>>> so that drivers can register to get called whenever an Oops is
>>>>> triggered.
>>>>
>>>> But we already have a panic notifier list. Why create a new one?
>>>> What's wrong with the existing one that doesn't work properly for you?
>>>
>>> AFAICT, the panic notifier list doesn't get called on oops.
>>
>> Have you tried playing with panic_on_oops ?
>
> Yes. We actually run in that setup. However, oops != panic. They are 2
> distinct events. Sometimes we panic without the oops under certain
> situations. That is why it is desirable to have 2 distinct events.
That's a circular statement: They are distinct events, so it is
desirable that they be distinct events?
Set a flag, a la oops_in_progress (unfortunately name, as it's called
during a panic too). Call it... oops_really_in_progress. Then will
the panic notifier list suffice?
Jeff
next prev parent reply other threads:[~2011-01-25 21:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 0:24 [PATCH v1 0/6] google firmware support Mike Waychison
2011-01-25 0:24 ` [PATCH v1 1/6] Add oops notification chain Mike Waychison
2011-01-25 2:06 ` Greg KH
2011-01-25 20:01 ` Mike Waychison
2011-01-25 21:36 ` Jeff Garzik
2011-01-25 21:43 ` Aaron Durbin
2011-01-25 21:54 ` Jeff Garzik [this message]
2011-01-25 22:21 ` Aaron Durbin
2011-01-26 2:48 ` Greg KH
2011-01-26 21:50 ` Mike Waychison
2011-01-25 0:24 ` [PATCH v1 2/6] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-01-25 0:24 ` [PATCH v1 3/6] driver: Google EFI SMI Mike Waychison
2011-01-25 3:17 ` Greg KH
2011-01-25 23:12 ` Mike Waychison
2011-01-26 2:46 ` Greg KH
2011-01-26 23:58 ` Mike Waychison
2011-01-27 1:22 ` Mike Waychison
2011-01-27 23:41 ` Mike Waychison
2011-01-28 2:56 ` Greg KH
2011-02-20 4:44 ` Matt Domsch
2011-02-21 13:58 ` Matthew Garrett
2011-01-27 10:43 ` Alan Cox
2011-01-27 19:22 ` Mike Waychison
2011-01-28 2:55 ` Greg KH
2011-01-28 2:59 ` Greg KH
2011-01-25 0:24 ` [PATCH v1 4/6] driver: Google Bootlog Mike Waychison
2011-01-25 0:49 ` Alan Cox
2011-01-25 1:38 ` Mike Waychison
2011-01-25 9:43 ` Alan Cox
2011-01-25 0:25 ` [PATCH v1 5/6] Allow prepending to the dmesg Mike Waychison
2011-01-25 1:01 ` Andrew Morton
2011-01-25 0:25 ` [PATCH v1 6/6] driver: Google Memory Console Mike Waychison
2011-01-25 2:00 ` Greg KH
2011-01-25 3:01 ` [PATCH v1 0/6] google firmware support Greg KH
2011-01-25 19:58 ` Mike Waychison
2011-01-26 2:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3F4699.60809@garzik.org \
--to=jeff@garzik.org \
--cc=adurbin@google.com \
--cc=dlaurie@google.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=san@google.com \
--cc=thockin@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox