public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Evan Lavelle <sa212+lkml@cyconix.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Kernel deferring driver 'close' call: workaround?
Date: Wed, 26 Jan 2011 15:29:47 +0000	[thread overview]
Message-ID: <4D403DEB.8040208@cyconix.com> (raw)
In-Reply-To: <20110126143851.711c57df@lxorguk.ukuu.org.uk>

On 26/01/2011 14:38, Alan Cox wrote:
> On Wed, 26 Jan 2011 14:29:50 +0000
> Evan Lavelle<sa212+lkml@cyconix.com>  wrote:
>
>> On 26/01/2011 13:17, Alan Cox wrote:
>>
>>> I imagine the user has a bug in their app. The close method is called on
>>> the final close of the handle. That means if for example you do something
>>> like fork off a child process and forget to close the handle then it
>>> won't actually close down until the final user closes it.
>>
>> That was my first reaction, but the strace output only shows an open and
>> close of two shared libs, open and close for this board, some mmaps from
>> the driver, and the basic brk/fstat/etc stuff. Unfortunately, I haven't
>> got the app source, or even the board... :(
>
> An mmap reference counts as an open .... it won't be released until the
> mmaps are gone

Excellent! Fixed - well done.

-Evan

      reply	other threads:[~2011-01-26 15:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 12:48 Kernel deferring driver 'close' call: workaround? Evan Lavelle
2011-01-26 13:17 ` Alan Cox
2011-01-26 14:29   ` Evan Lavelle
2011-01-26 14:38     ` Alan Cox
2011-01-26 15:29       ` Evan Lavelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D403DEB.8040208@cyconix.com \
    --to=sa212+lkml@cyconix.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox