From: Coly Li <i@coly.li>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] use BUG_ON correctly
Date: Thu, 27 Jan 2011 15:19:05 +0800 [thread overview]
Message-ID: <4D411C69.8080503@coly.li> (raw)
In-Reply-To: <AANLkTikPtCL++c47vPCzqBh_veG+fzZWR2w2xAYDUgw=@mail.gmail.com>
On 2011年01月27日 14:20, Yong Zhang Wrote:
> On Thu, Jan 27, 2011 at 2:38 PM, Coly Li<i@coly.li> wrote:
>> On 2011年01月27日 14:07, Yong Zhang Wrote:
>>>
>>> On Thu, Jan 27, 2011 at 2:21 PM, Coly Li<i@coly.li> wrote:
>>>>
>>>> On 2011年01月27日 10:02, Yong Zhang Wrote:
>>>>>
>>>>> On Thu, Jan 27, 2011 at 2:39 AM, Coly Li<bosong.ly@taobao.com> wrote:
>>>>>>
>>>>>> BUG_ON() already uses unlikely() inside its definition if possible,
>>>>>
>>>>> It's true for asm-generic/bug.h.
>>>>>
>>>>> But for archs which has defined HAVE_ARCH_BUG,
>>>>> unlikely() is not always included in it.
>>>>>
>>>>
>>>> IMHO, if this condition happens, it should be a bug of the arch
>>>> implementation,
>>>
>>> So that means we should fix that first :)
>>>
>>
>> Could you please to identify a piece of kernel code which provides an
>> example as the condition you mentioned ?
>> So I can have a look firstly.
>
> # line filename / context / line
> 1 35 arch/mips/include/asm/bug.h<<HAVE_ARCH_BUG_ON>>
> #define HAVE_ARCH_BUG_ON
> 2 115 arch/powerpc/include/asm/bug.h<<HAVE_ARCH_BUG_ON>>
> #define HAVE_ARCH_BUG_ON
I don't find arch dependent implementation of BUG_ON from the above files. Do I miss something ?
--
Coly Li
next prev parent reply other threads:[~2011-01-27 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 18:39 [PATCH 0/6] use BUG_ON correctly Coly Li
2011-01-26 18:39 ` [PATCH 1/6] mm: use BUG_ON correctly in nommu.c Coly Li
2011-01-26 18:39 ` [PATCH 2/6] dma: use BUG_ON correctly in iop-adma.c Coly Li
2011-01-26 18:39 ` [PATCH 3/6] dma: use BUG_ON correctly in mv_xor.c Coly Li
2011-01-26 18:39 ` [PATCH 4/6] dma: use BUG_ON correctly in ppc4xx/adam.c Coly Li
2011-01-26 18:39 ` [PATCH 5/6] wl_cfg80211.c: use BUG_ON correctly Coly Li
2011-01-26 18:39 ` [PATCH 6/6] scsi_lib.c: " Coly Li
2011-01-27 2:02 ` [PATCH 0/6] " Yong Zhang
2011-01-27 6:21 ` Coly Li
2011-01-27 6:07 ` Yong Zhang
2011-01-27 6:38 ` Coly Li
2011-01-27 6:20 ` Yong Zhang
2011-01-27 7:19 ` Coly Li [this message]
2011-01-27 7:41 ` WANG Cong
-- strict thread matches above, loose matches on Subject: below --
2011-01-26 18:54 Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D411C69.8080503@coly.li \
--to=i@coly.li \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox