From: "Fabio M. Di NItto" <fabbione@fabbione.net>
To: David Miller <davem@davemloft.net>
Cc: fdinitto@redhat.com, akpm@linux-foundation.org,
rdunlap@xenotime.net, jmorris@namei.org, kees.cook@canonical.com,
mingo@elte.hu, namhyung@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console: allow to retain boot console via boot option keep_bootcon
Date: Thu, 27 Jan 2011 21:52:25 +0100 [thread overview]
Message-ID: <4D41DB09.5050802@fabbione.net> (raw)
In-Reply-To: <20110127.124752.71123363.davem@davemloft.net>
On 01/27/2011 09:47 PM, David Miller wrote:
> From: "Fabio M. Di Nitto" <fdinitto@redhat.com>
> Date: Thu, 27 Jan 2011 15:35:19 +0100
>
>> According to kernel/print.k:
>>
>>> /*
>>> * By unregistering the bootconsoles after we enable the real console
>>> * we get the "console xxx enabled" message on all the consoles -
>>> * boot consoles, real consoles, etc - this is to ensure that end
>>> * users know there might be something in the kernel's log buffer that
>>> * went to the bootconsole (that they do not see on the real console)
>>> */
>>
>> but my understanding, and please correct if I am wrong, is that when we
>> load or initialize modules such as fbcon (I made this patch debugging a
>> crash in atyfb), a console is indeed registered and bootconsole disable,
>> while in reality the real console is not there yet (in my case fbcon was
>> loaded but not atyfb yet).
>> At a later stage, once atyfb is loaded, it registers with fbcon and then
>> the console output starts again.
>
> It's not exactly "fbcon", it's the "VT" driver.
Thanks for the clarification. I spotted both VT and fbcon (as they are
the only two that register as console driver effectively) and of course
picked the wrong one ;)
> That loads, and nothing has attached to VT yet to provide the actual
> console hookup.
at least I got this part right...
>
> "fbcon" waits until a usable driver registers before it hooks itself
> into the "VT" layer.
>
> So this is why we have this large gap of time with no console output.
> It's because VT registers before it actually is able to provide
> console output services, and frankly that's a bug. :-)
Ok, I have no idea how complex and delicate that code is, but I'll try
to see if we can actually fix VT to behave as fbcon rather than adding
this patch as workaround.
Thanks
Fabio
prev parent reply other threads:[~2011-01-27 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 8:40 [PATCH] console: allow to retain boot console via boot option keep_bootcon Fabio M. Di Nitto
2011-01-20 0:19 ` Andrew Morton
2011-01-20 6:09 ` Fabio M. Di Nitto
2011-01-27 14:35 ` Fabio M. Di Nitto
2011-01-27 20:47 ` David Miller
2011-01-27 20:52 ` Fabio M. Di NItto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D41DB09.5050802@fabbione.net \
--to=fabbione@fabbione.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fdinitto@redhat.com \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox