Re: [PATCH v8 03/12] media: Entities, pads and links

Laurent Pinchart
2011-02-08T13:35:22Z

Hi Hans,

On Friday 04 February 2011 11:20:37 Hans Verkuil wrote:
> On Thursday, January 27, 2011 13:30:28 Laurent Pinchart wrote:

<snip>

> > +#define MEDIA_ENT_TYPE_SHIFT 16
> > +#define MEDIA_ENT_TYPE_MASK 0x00ff0000
> > +#define MEDIA_ENT_SUBTYPE_MASK 0x0000ffff
> > +
> > +#define MEDIA_ENT_T_DEVNODE (1 << MEDIA_ENTITY_TYPE_SHIFT)
> > +#define MEDIA_ENT_T_DEVNODE_V4L (MEDIA_ENTITY_T_DEVNODE + 1)
> > +#define MEDIA_ENT_T_DEVNODE_FB (MEDIA_ENTITY_T_DEVNODE + 2)
> > +#define MEDIA_ENT_T_DEVNODE_ALSA (MEDIA_ENTITY_T_DEVNODE + 3)
> > +#define MEDIA_ENT_T_DEVNODE_DVB (MEDIA_ENTITY_T_DEVNODE + 4)
> > +
> > +#define MEDIA_ENT_T_V4L2_SUBDEV (2 << MEDIA_ENTITY_TYPE_SHIFT)
> > +#define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENTITY_T_V4L2_SUBDEV + 1)
> > +#define MEDIA_ENT_T_V4L2_SUBDEV_FLASH (MEDIA_ENTITY_T_V4L2_SUBDEV + 2)
> > +#define MEDIA_ENT_T_V4L2_SUBDEV_LENS (MEDIA_ENTITY_T_V4L2_SUBDEV + 3)
>
> MEDIA_ENTITY_? That should be MEDIA_ENT_. It looks like this was never
> compiled...

Oops. I probably forgot to compile this intermediate patch (the end result is
correct though). I'll fix it.

--
Regards,

Laurent Pinchart