Re: [PATCH v8 03/12] media: Entities, pads and links

Sakari Ailus
2011-01-28T10:52:23Z

Hi Laurent,

Thanks for the patches!

I've got one comment that I should have made long time ago... Pads are
inputs or outputs... or: are they sinks or sources? I recall that it was
agreed on some occasion that sink and source are much less ambiguous and
they should be used instead.

So we'd have MEDIA_PAD_FL_{SINK,SOURCE}, for example. Currently the
source and documentation is using input/output and source/sink
interchangeably. I think sink and source should be used all the time.

What do you think?

Regards,

--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com