From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: David Brownell <david-b@pacbell.net>,
Eric Miao <eric.y.miao@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: Make gpio_{request,free}_array gpio array parameter const
Date: Sun, 30 Jan 2011 20:07:08 +0100 [thread overview]
Message-ID: <4D45B6DC.9000603@metafoo.de> (raw)
In-Reply-To: <20110130184914.GB12801@pengutronix.de>
On 01/30/2011 07:49 PM, Wolfram Sang wrote:
> On Sat, Jan 29, 2011 at 04:21:21PM +0100, Lars-Peter Clausen wrote:
>> gpio_{request,free}_array should not (and do not) modify the passed gpio array,
>> so make the parameter const.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
> Looks good to me. What about the users of these calls (luckily there don't seem
> to be many)?
>
> Kind regards,
>
> Wolfram
>
Hi
Well, they could, but don't have to, make their gpio array const now, if it is not
otherwise modified. But I guess that is something for a follow-up patch.
- Lars
prev parent reply other threads:[~2011-01-30 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-29 15:21 [PATCH] gpio: Make gpio_{request,free}_array gpio array parameter const Lars-Peter Clausen
2011-01-29 16:26 ` Eric Miao
2011-01-30 18:49 ` Wolfram Sang
2011-01-30 19:07 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D45B6DC.9000603@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox