From: Cong Wang <amwang@redhat.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] kmap_atomic: remove the second parameter
Date: Mon, 31 Jan 2011 10:24:28 +0800 [thread overview]
Message-ID: <4D461D5C.6090401@redhat.com> (raw)
In-Reply-To: <20110130103348.GA2528@joi.lan>
于 2011年01月30日 18:33, Marcin Slusarz 写道:
> On Sun, Jan 30, 2011 at 05:46:57PM +0800, Amerigo Wang wrote:
>>
>> (...)
>>
>> diff --git a/sound/oss/Makefile b/sound/oss/Makefile
>> index 96f14dc..90ffb99 100644
>> --- a/sound/oss/Makefile
>> +++ b/sound/oss/Makefile
>> @@ -87,7 +87,7 @@ ifeq ($(CONFIG_PSS_HAVE_BOOT),y)
>> $(obj)/bin2hex pss_synth< $< > $@
>> else
>> $(obj)/pss_boot.h:
>> - ( \
>> + $(Q)( \
>> echo 'static unsigned char * pss_synth = NULL;'; \
>> echo 'static int pss_synthLen = 0;'; \
>> )> $@
>> @@ -102,7 +102,7 @@ ifeq ($(CONFIG_TRIX_HAVE_BOOT),y)
>> $(obj)/hex2hex -i trix_boot< $< > $@
>> else
>> $(obj)/trix_boot.h:
>> - ( \
>> + $(Q)( \
>> echo 'static unsigned char * trix_boot = NULL;'; \
>> echo 'static int trix_boot_len = 0;'; \
>> )> $@
>> --
>
> does it belong here?
>
Oh, of course not. My bad, I forgot to revert the previous patch before
making this one! :(
Thanks!
next prev parent reply other threads:[~2011-01-31 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 9:46 [PATCH 1/4] kmap_atomic: remove the second parameter Amerigo Wang
2011-01-30 9:46 ` [PATCH 2/4] kmap_atomic: remove dead code in ieee80211 staging code Amerigo Wang
2011-01-30 9:46 ` [PATCH 3/4] kmap_atomic: Remove some function parameters of enum km_type Amerigo Wang
2011-01-30 9:47 ` [PATCH 4/4] kmap_atomic: remove KM_* types except KM_TYPE_NR Amerigo Wang
2011-01-30 10:33 ` [PATCH 1/4] kmap_atomic: remove the second parameter Marcin Slusarz
2011-01-31 2:24 ` Cong Wang [this message]
2011-01-31 9:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D461D5C.6090401@redhat.com \
--to=amwang@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox