Re: [RFC -v7 PATCH 4/7] Add yield_to(task, preempt) functionality.

Rik van Riel
2011-01-31T18:12:01Z

On 01/31/2011 06:49 AM, Peter Zijlstra wrote:
> On Wed, 2011-01-26 at 17:21 -0500, Rik van Riel wrote:

>> + if (yielded)
>> + yield();
>> +
>> + return yielded;
>> +}
>> +EXPORT_SYMBOL_GPL(yield_to);
>
> yield() will again acquire rq->lock.. not not simply have
> ->yield_to_task() do everything required and make that an unconditional
> schedule()?

I wanted to reduce code duplication, since this code path
should not be taken all that frequently. But hey, you're
the maintainer, so I'll implement it your way :)

The patches should be on the way later today :)

--
All rights reversed