Re: [RFC -v7 PATCH 3/7] sched: use a buddy to implement yield_task_fair

Rik van Riel
2011-01-31T15:03:17Z

On 01/31/2011 06:47 AM, Peter Zijlstra wrote:
> On Wed, 2011-01-26 at 17:21 -0500, Rik van Riel wrote:
>
>> +static struct sched_entity *__pick_second_entity(struct cfs_rq *cfs_rq)
>> +{
>> + struct rb_node *left = cfs_rq->rb_leftmost;
>> + struct rb_node *second;
>> +
>> + if (!left)
>> + return NULL;
>> +
>> + second = rb_next(left);
>> +
>> + if (!second)
>> + second = left;
>> +
>> + return rb_entry(second, struct sched_entity, run_node);
>> +}
>
> I would still prefer:
>
> sed -i 's/__pick_next_entity/__pick_first_entity/g' kernel/sched*.[ch]

Ahhh, now I understand what you want. I'll get right on it.

> You seem to have lost the hunk removing sysctl_sched_compat_yield from
> kernel/sysctl.c :-)

Let me take care of that, too.

--
All rights reversed