From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, George Spelvin <linux@horizon.com>,
Meelis Roos <mroos@linux.ee>, Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [PATCH] perf, x86: P4 PMU -- Fix unflagged overflows test
Date: Fri, 04 Feb 2011 20:32:17 +0300 [thread overview]
Message-ID: <4D4C3821.5090403@gmail.com> (raw)
In-Reply-To: <20110204165944.GB21209@redhat.com>
On 02/04/2011 07:59 PM, Don Zickus wrote:
> On Fri, Feb 04, 2011 at 03:17:28PM +0300, Cyrill Gorcunov wrote:
>> Please apply it, sorry for non-inlined patch (have a web access only at moment).
>>
>> Note that I've tested the patch on non-HT machine so if someone have HT'ed one
>> -- it would be great to test the patch there.
>
> Hmm. For some reason, when I enable the kgdb testsuite, the box fails to
> boot with hardlockup issues. It seems like the code is swallowing the
> NMIs? I basically applied this patch on top of 2.6.38-rc3 and ran it on my
> Xeon box (p4 w/HT).
>
> Cheers,
> Don
Interesting, seems old kgdb issue got back. The former unknown nmi problem
is due to commit 047a3772feaae8e43d81d790f3d3f80dae8ae676 which assumed that
counter stays zero when unflagged overflow happened, but it seems this is not
what happens on hw level. I noted that at moment of nmi the counter reached
some positive value so the new patch simply checks for negative bit being set.
I must admit I forgot to test with kgdb testsuite at bootup time and I'll
be able to test this at monday in best case. I'll try to figure out what might
happen by code reading for a while (the only idea comes is that nmi from kgdb
get slipped with one issued by a perf).
--
Cyrill
next prev parent reply other threads:[~2011-02-04 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 12:17 [PATCH] perf, x86: P4 PMU -- Fix unflagged overflows test Cyrill Gorcunov
2011-02-04 16:59 ` Don Zickus
2011-02-04 17:32 ` Cyrill Gorcunov [this message]
2011-02-06 19:21 ` Cyrill Gorcunov
2011-02-07 17:22 ` Cyrill Gorcunov
2011-02-08 14:26 ` George Spelvin
2011-02-08 14:38 ` Cyrill Gorcunov
2011-02-05 2:28 ` George Spelvin
2011-02-05 8:40 ` Cyrill Gorcunov
2011-02-05 9:15 ` George Spelvin
2011-02-05 9:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4C3821.5090403@gmail.com \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).