* [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique
@ 2011-02-04 17:48 John Villalovos
2011-02-04 18:58 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: John Villalovos @ 2011-02-04 17:48 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Yinghai Lu,
Eric W. Biederman, John L. Villalovos, prarit
x86, apic: Make "broken BIOS!!" messages unique
There are five identical "broken BIOS!!" messages. This patch makes each
message unique so that it is easier to determine which message was actually
printed.
The 'inconceivable' messages are because it should not be possible to reach
those code paths.
Signed-off-by: John L. Villalovos <john.l.villalovos@intel.com>
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..b0c40c3 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: polarity!!\n");
polarity = 1;
break;
}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: inconceivable polarity!!\n");
polarity = 1;
break;
}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
}
default:
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: unknown bus type!!\n");
trigger = 1;
break;
}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: trigger!!\n");
trigger = 1;
break;
}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: inconceivable trigger!!\n");
trigger = 0;
break;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique
2011-02-04 17:48 [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique John Villalovos
@ 2011-02-04 18:58 ` H. Peter Anvin
2011-02-04 22:00 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2011-02-04 18:58 UTC (permalink / raw)
To: John Villalovos
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, x86, Yinghai Lu,
Eric W. Biederman, John L. Villalovos, prarit
On 02/04/2011 09:48 AM, John Villalovos wrote:
> x86, apic: Make "broken BIOS!!" messages unique
>
> There are five identical "broken BIOS!!" messages. This patch makes each
> message unique so that it is easier to determine which message was actually
> printed.
>
> The 'inconceivable' messages are because it should not be possible to reach
> those code paths.
How about labelling these "MPBIOS" or so, too?
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique
2011-02-04 18:58 ` H. Peter Anvin
@ 2011-02-04 22:00 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2011-02-04 22:00 UTC (permalink / raw)
To: H. Peter Anvin
Cc: John Villalovos, linux-kernel, Thomas Gleixner, Ingo Molnar, x86,
Yinghai Lu, Eric W. Biederman, John L. Villalovos, prarit
* H. Peter Anvin <hpa@zytor.com> wrote:
> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> >
> > There are five identical "broken BIOS!!" messages. This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> >
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
>
> How about labelling these "MPBIOS" or so, too?
Yeah.
Also, the messages do not need to shout i suspect - the '!!' can be removed as well.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-04 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-04 17:48 [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique John Villalovos
2011-02-04 18:58 ` H. Peter Anvin
2011-02-04 22:00 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox