From: Nitin Gupta <ngupta@vflare.org>
To: Greg KH <greg@kroah.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zram: fix data corruption issue
Date: Sun, 06 Feb 2011 00:33:33 -0500 [thread overview]
Message-ID: <4D4E32AD.5000102@vflare.org> (raw)
In-Reply-To: <20110206051111.GA4816@kroah.com>
On 02/06/2011 12:11 AM, Greg KH wrote:
> On Sun, Feb 06, 2011 at 12:03:12AM -0500, Nitin Gupta wrote:
>> On 02/06/2011 12:00 AM, Greg KH wrote:
>>> On Sat, Feb 05, 2011 at 08:34:20PM -0500, Nitin Gupta wrote:
>>>> In zram_read() and zram_write() we were not incrementing the
>>>> index number and thus were reading/writing values from/to
>>>> incorrect sectors on zram disk, resulting in data corruption.
>>>
>>> Is this something that needs to go into .38 or can it wait until .39?
>>>
>>
>>
>> This really needs to get into .38 or users will see random data
>> corruption on zram devices.
>
> Ok, I'll queue it up for there. What about .37 and/or .36?
>
The same problem exists on .37 and .36. I just checked that the same
patch applies cleanly to both these version so may be included in their
respective maintenance releases.
Thanks,
Nitin
prev parent reply other threads:[~2011-02-06 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 1:34 [PATCH] zram: fix data corruption issue Nitin Gupta
2011-02-06 5:00 ` Greg KH
2011-02-06 5:03 ` Nitin Gupta
2011-02-06 5:11 ` Greg KH
2011-02-06 5:33 ` Nitin Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4E32AD.5000102@vflare.org \
--to=ngupta@vflare.org \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox