From: Pavel Vasilyev <pavel@pavlinux.ru>
To: Andy Isaacson <adi@hexapodia.org>
Subject: Re: CONFIG_KERNEL_XZ obscure build failure if xz(1) not installed
Date: Thu, 10 Feb 2011 00:14:40 +0300 [thread overview]
Message-ID: <4D5303C0.7010907@pavlinux.ru> (raw)
In-Reply-To: <20110209203841.GQ11874@hexapodia.org>
09.02.2011 23:38, Andy Isaacson пишет:
> On Wed, Feb 09, 2011 at 11:07:32PM +0300, Pavel Vasilyev wrote:
>>> The failure is obscured by trailing make output, and since a broken
>>> bzImage is created, "make install" succeeds, and the first visible
> [snip]
>> :)
>>
>> Signed-off-by: Pavel Vasilyev <pavel@pavlinux.ru>
>> ---
>> diff --git a/scripts/xz_wrap.sh b/scripts/xz_wrap.sh
>> index 17a5798..5ec9d36 100644
>> --- a/scripts/xz_wrap.sh
>> +++ b/scripts/xz_wrap.sh
>> @@ -20,4 +20,4 @@ case $ARCH in
>> sparc) BCJ=--sparc ;;
>> esac
>>
>> -exec xz --check=crc32 $BCJ --lzma2=$LZMA2OPTS,dict=32MiB
>> +exec xz --check=crc32 $BCJ --lzma2=$LZMA2OPTS,dict=32MiB || exit 1
>>
>
> I get the same behavior with and without your patch, tested with both
> bash and dash. (FWIW, /bin/sh on my systems is a symlink to /bin/dash.)
>
# mv /usr/bin/xz /
# rm arch/x86/boot/compressed/vmlinux.bin*
# rm arch/x86/boot/bzImage
# make
# make
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK include/linux/version.h
make[2]: `scripts/unifdef' is up to date.
XZKERN arch/x86/boot/compressed/vmlinux.bin.xz
/media/kernel/linux-2.6/scripts/xz_wrap.sh: line 23: exec: xz: not found
make[2]: *** [arch/x86/boot/compressed/vmlinux.bin.xz] Error 1
make[1]: *** [arch/x86/boot/compressed/vmlinux] Error 2
make: *** [bzImage] Error 2
# make install
sh /media/kernel/linux-2.6/arch/x86/boot/install.sh 2.6.38-rc4+
arch/x86/boot/bzImage \
System.map "/boot"
*** Missing file: arch/x86/boot/bzImage
*** You need to run "make" before "make install".
make[1]: *** [install] Error 1
make: *** [install] Error 2
All work, without and with patch. :-/
# sh --version
GNU bash, version 4.1.9(1)-release (x86_64-suse-linux-gnu)
--
Pavel.
next prev parent reply other threads:[~2011-02-09 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 19:52 CONFIG_KERNEL_XZ obscure build failure if xz(1) not installed Andy Isaacson
2011-02-09 20:07 ` Pavel Vasilyev
2011-02-09 20:38 ` Andy Isaacson
2011-02-09 21:14 ` Pavel Vasilyev [this message]
2011-02-09 21:19 ` H. Peter Anvin
2011-02-09 22:01 ` Lasse Collin
2011-02-09 23:23 ` Andy Isaacson
2011-02-10 12:24 ` Lasse Collin
2011-02-10 13:15 ` Lasse Collin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5303C0.7010907@pavlinux.ru \
--to=pavel@pavlinux.ru \
--cc=adi@hexapodia.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox