* [GIT PULL] TPM timeout fix
@ 2011-02-11 4:09 Rajiv Andrade
2011-02-11 6:38 ` James Morris
2011-02-11 7:59 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: Rajiv Andrade @ 2011-02-11 4:09 UTC (permalink / raw)
To: James Morris; +Cc: linux-kernel, Stefan Berger, Guillaume Chazarain
Hi James,
Please pull from:
git://tpmdd.git.sourceforge.net/gitroot/tpmdd/tpmdd/ for-james
The following change corrects the logic used to extract the timeouts returned from a TPM.
These values are used subsequently in the TPM device driver, and if relying on the default values,
some commands may not have its proper timeout considered. This is a bugfix for the current linus tree.
Stefan Berger (1):
tpm_tis: Use timeouts returned from TPM
Diffstat:
drivers/char/tpm/tpm.c | 18 ++++++++++++++++--
drivers/char/tpm/tpm.h | 2 ++
drivers/char/tpm/tpm_tis.c | 4 +++-
3 files changed, 21 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] TPM timeout fix
2011-02-11 4:09 [GIT PULL] TPM timeout fix Rajiv Andrade
@ 2011-02-11 6:38 ` James Morris
2011-02-11 7:59 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2011-02-11 6:38 UTC (permalink / raw)
To: Rajiv Andrade; +Cc: linux-kernel, Stefan Berger, Guillaume Chazarain
On Fri, 11 Feb 2011, Rajiv Andrade wrote:
> Hi James,
>
> Please pull from:
> git://tpmdd.git.sourceforge.net/gitroot/tpmdd/tpmdd/ for-james
>
> The following change corrects the logic used to extract the timeouts returned
> from a TPM.
> These values are used subsequently in the TPM device driver, and if relying on
> the default values,
> some commands may not have its proper timeout considered. This is a bugfix for
> the current linus tree.
>
> Stefan Berger (1):
> tpm_tis: Use timeouts returned from TPM
Thanks, applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#for-linus
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] TPM timeout fix
2011-02-11 4:09 [GIT PULL] TPM timeout fix Rajiv Andrade
2011-02-11 6:38 ` James Morris
@ 2011-02-11 7:59 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2011-02-11 7:59 UTC (permalink / raw)
To: Rajiv Andrade
Cc: James Morris, linux-kernel, Stefan Berger, Guillaume Chazarain
On Fri, 11 Feb 2011 02:09:44 -0200 Rajiv Andrade <srajiv@linux.vnet.ibm.com> wrote:
> Hi James,
>
> Please pull from:
> git://tpmdd.git.sourceforge.net/gitroot/tpmdd/tpmdd/ for-james
>
> The following change corrects the logic used to extract the timeouts returned from a TPM.
> These values are used subsequently in the TPM device driver, and if relying on the default values,
> some commands may not have its proper timeout considered. This is a bugfix for the current linus tree.
>
> Stefan Berger (1):
> tpm_tis: Use timeouts returned from TPM
>
> Diffstat:
> drivers/char/tpm/tpm.c | 18 ++++++++++++++++--
> drivers/char/tpm/tpm.h | 2 ++
> drivers/char/tpm/tpm_tis.c | 4 +++-
> 3 files changed, 21 insertions(+), 3 deletions(-)
Please include the full patch in the email unless it's huge, so others
don't need to jump through hoops to see the change.
Is this bug present in 2.6.37 and earlier? If so, should we fix it in
those kernels?
<finds "tpm_tis: Use timeouts returned from TPM" on the mailing list>
OK, earlier kernels do need fixing. Hopefully you included
"Cc: <stable@kernel.org>" in the changelog which we weren't shown.
That patch adds a new sysfs file but doesn't alter any documentation
file for it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-11 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-11 4:09 [GIT PULL] TPM timeout fix Rajiv Andrade
2011-02-11 6:38 ` James Morris
2011-02-11 7:59 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox