From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903Ab1BNWKO (ORCPT ); Mon, 14 Feb 2011 17:10:14 -0500 Received: from smtp-68.nebula.fi ([83.145.220.68]:60683 "EHLO smtp-68.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067Ab1BNWKL (ORCPT ); Mon, 14 Feb 2011 17:10:11 -0500 X-Greylist: delayed 456 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Feb 2011 17:10:11 EST Message-ID: <4D59A693.2080106@iki.fi> Date: Tue, 15 Feb 2011 00:02:59 +0200 From: Sakari Ailus User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101123 SeaMonkey/2.0.11 MIME-Version: 1.0 To: Randy Dunlap CC: Stephen Rothwell , netdev , linux-pci@vger.kernel.org, linux-next@vger.kernel.org, LKML , davem@davemloft.net, Jesse Barnes Subject: Re: [PATCH -next] PCI: fix tlan build when CONFIG_PCI is not enabled References: <20110214181137.ee8d4c08.sfr@canb.auug.org.au> <20110214122750.e1e03bc8.randy.dunlap@oracle.com> <4D599F60.4010800@iki.fi> In-Reply-To: <4D599F60.4010800@iki.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sakari Ailus wrote: > Randy Dunlap wrote: >> From: Randy Dunlap >> >> When CONFIG_PCI is not enabled, tlan.c has a build error: >> drivers/net/tlan.c:503: error: implicit declaration of function 'pci_wake_from_d3' >> >> so add an inline function stub for this function to pci.h when >> PCI is not enabled, similar to other stubbed PCI functions. >> >> Signed-off-by: Randy Dunlap >> Cc: Sakari Ailus > > Hi Randy, > > I think this issue in tlan driver was caused by my recent patch which > added the suspend/resume support to tlan: > > > > There apparently are tlan cards which are EISA (not PCI) which I forgot > when writing the patch. The suspend/resume has been only tested with PCI > as I have no EISA bus (let alone EISA tlan card!). Right; so I suppose there's no PM support in EISA anyway. Other pci functions appear to be no-ops when CONFIG_PCI isn't defined so this patch seems right to me --- and no changes are needed in the tlan driver. Acked-by: Sakari Ailus -- Sakari Ailus sakari.ailus@iki.fi