public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] leds: make *struct gpio_led_platform_data.leds const
Date: Tue, 15 Feb 2011 01:21:57 +0100	[thread overview]
Message-ID: <4D59C725.20408@metafoo.de> (raw)
In-Reply-To: <20110214195802.GI13279@pengutronix.de>

On 02/14/2011 08:58 PM, Uwe Kleine-König wrote:
> Hello Richard,
> 
> On Wed, Jan 19, 2011 at 10:47:46AM +0100, Uwe Kleine-König wrote:
>> ... and fix a typo.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ping
> 

Andrew Morton merges patches for the LED subsystem these days, so adding him to Cc.


>> ---
>>  drivers/leds/leds-net5501.c |    2 +-
>>  include/linux/leds.h        |    4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/leds/leds-net5501.c b/drivers/leds/leds-net5501.c
>> index 1739557..7e764b8 100644
>> --- a/drivers/leds/leds-net5501.c
>> +++ b/drivers/leds/leds-net5501.c
>> @@ -19,7 +19,7 @@
>>  
>>  #include <asm/geode.h>
>>  
>> -static struct gpio_led net5501_leds[] = {
>> +static const struct gpio_led net5501_leds[] = {
>>  	{
>>  		.name = "error",
>>  		.gpio = 6,
>> diff --git a/include/linux/leds.h b/include/linux/leds.h
>> index 0f19df9..383811d 100644
>> --- a/include/linux/leds.h
>> +++ b/include/linux/leds.h
>> @@ -194,11 +194,11 @@ struct gpio_led {
>>  
>>  struct gpio_led_platform_data {
>>  	int 		num_leds;
>> -	struct gpio_led *leds;
>> +	const struct gpio_led *leds;
>>  
>>  #define GPIO_LED_NO_BLINK_LOW	0	/* No blink GPIO state low */
>>  #define GPIO_LED_NO_BLINK_HIGH	1	/* No blink GPIO state high */
>> -#define GPIO_LED_BLINK		2	/* Plase, blink */
>> +#define GPIO_LED_BLINK		2	/* Please, blink */
>>  	int		(*gpio_blink_set)(unsigned gpio, int state,
>>  					unsigned long *delay_on,
>>  					unsigned long *delay_off);
>> -- 
>> 1.7.2.3
>>
>>
> 


      reply	other threads:[~2011-02-15  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19  9:47 [PATCH] leds: make *struct gpio_led_platform_data.leds const Uwe Kleine-König
2011-02-14 19:58 ` Uwe Kleine-König
2011-02-15  0:21   ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D59C725.20408@metafoo.de \
    --to=lars@metafoo.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox