* [PATCH] usb_storage: realtek_cr patch: fix sparse warning
@ 2011-02-15 1:38 wei_wang
2011-02-15 8:50 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: wei_wang @ 2011-02-15 1:38 UTC (permalink / raw)
To: gregkh, devel, linux-kernel; +Cc: wwang
From: wwang <wei_wang@realsil.com.cn>
Fix some sparse warning for realtek_cr patch
Signed-off-by: wwang <wei_wang@realsil.com.cn>
---
drivers/usb/storage/realtek_cr.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index c2bebb3..4f6b25f 100644
--- a/drivers/usb/storage/realtek_cr.c
+++ b/drivers/usb/storage/realtek_cr.c
@@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
.driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
}
-struct usb_device_id realtek_cr_ids[] = {
+static struct usb_device_id realtek_cr_ids[] = {
# include "unusual_realtek.h"
{ } /* Terminating entry */
};
@@ -570,7 +570,7 @@ static void realtek_cr_destructor(void *extra)
}
#ifdef CONFIG_PM
-void realtek_pm_hook(struct us_data *us, int pm_state)
+static void realtek_pm_hook(struct us_data *us, int pm_state)
{
if (pm_state == US_SUSPEND)
(void)config_autodelink_before_power_down(us);
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb_storage: realtek_cr patch: fix sparse warning
2011-02-15 1:38 [PATCH] usb_storage: realtek_cr patch: fix sparse warning wei_wang
@ 2011-02-15 8:50 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2011-02-15 8:50 UTC (permalink / raw)
To: wei_wang; +Cc: gregkh, devel, linux-kernel
On 02/15/2011 02:38 AM, wei_wang@realsil.com.cn wrote:
> From: wwang <wei_wang@realsil.com.cn>
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang <wei_wang@realsil.com.cn>
> ---
> drivers/usb/storage/realtek_cr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index c2bebb3..4f6b25f 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
> .driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
> }
>
> -struct usb_device_id realtek_cr_ids[] = {
> +static struct usb_device_id realtek_cr_ids[] = {
And it may be const too while you are at it...
regards,
--
js
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-15 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-15 1:38 [PATCH] usb_storage: realtek_cr patch: fix sparse warning wei_wang
2011-02-15 8:50 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox