From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, tj@kernel.org, yinghai@kernel.org,
ak@linux.intel.com, robert.richter@amd.com,
weidong.han@intel.com, gleb@redhat.com
Subject: Re: [PATCH 2/6] x86: ifdef enable_IR_x2apic() out
Date: Tue, 15 Feb 2011 14:47:50 +0100 [thread overview]
Message-ID: <4D5A8406.3030703@nachtwindheim.de> (raw)
In-Reply-To: <20110214110340.GC7140@elte.hu>
Am 14.02.2011 12:03, schrieb Ingo Molnar:
>
>
> * Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
>
>> +#ifdef CONFIG_X86_64
>> extern void enable_IR_x2apic(void);
>> +#endif
>
> Cannot we use the CONFIG_X86_X2APIC Kconfig switch here, instead of CONFIG_X86_64?
>
> enable_IR_x2apic() is not a 64-bit CPU feature.
>
> Thanks,
>
> Ingo
>
>
Thats what I had liked also.
At the time you moved the apic code from x86/kernel it was exactly that way.
But after that, in commit 937582382c71b75b29fbb92615629494e1a05ac0, it was explicitely moved out of
CONFIG_X86_X2APIC, which made that function also compile on 32bit machines, even if its not used there.
Also commit ce69a784504222c3ab6f1b3c357d09ec5772127a enabled the x2apic without interrupt remapping,
which means that CONFIG_X86_X2APIC depends on CONFIG_INTR_REMAP has been bypassed and so Kconfig is
broken/not representing what happens to the code.
So since I dont have an x2apic and therefore cannot test changes,
I decided for CONFIG_X86_64 without touching code which seems to work.
I wish I could offer something better here.
Greets,
Henrik Kretzschmar
next prev parent reply other threads:[~2011-02-15 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 10:00 [PATCH 1/6] x86: move ioapic_irq_destination_types Henrik Kretzschmar
2011-02-14 10:00 ` [PATCH 2/6] x86: ifdef enable_IR_x2apic() out Henrik Kretzschmar
2011-02-14 11:03 ` Ingo Molnar
2011-02-15 13:47 ` Henrik Kretzschmar [this message]
2011-02-15 14:13 ` Gleb Natapov
2011-02-14 10:00 ` [PATCH 3/6] x86: ifdef INTR_REMAP code out Henrik Kretzschmar
2011-02-14 11:02 ` Ingo Molnar
2011-02-14 10:00 ` [PATCH 4/6] x86: add dummy mp_save_irq() Henrik Kretzschmar
2011-02-14 10:00 ` [PATCH 5/6] x86: ifdef ioapic related function out Henrik Kretzschmar
2011-02-14 11:00 ` Ingo Molnar
2011-02-14 10:00 ` [PATCH 6/6] x86: makes X86_UP_IOAPIC work again Henrik Kretzschmar
2011-02-14 11:05 ` [PATCH 1/6] x86: move ioapic_irq_destination_types Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5A8406.3030703@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=ak@linux.intel.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=weidong.han@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox